Re: [PR] [ISSUE #7311] fix The object added by this appendStartAndShutdown method is incorrect [rocketmq]

["xdkxlk (via GitHub)" <gi...@apache.org>]

xdkxlk commented on code in PR #7312:
URL: https://github.com/apache/rocketmq/pull/7312#discussion_r1360074378


##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/DefaultGrpcMessingActivity.java:
##########
@@ -87,6 +87,7 @@ protected void init(MessagingProcessor messagingProcessor) {
         this.routeActivity = new RouteActivity(messagingProcessor, grpcClientSettingsManager, grpcChannelManager);
         this.clientActivity = new ClientActivity(messagingProcessor, grpcClientSettingsManager, grpcChannelManager);
 
+        this.appendShutdown(this.grpcChannelManager);

Review Comment:
   Although the start method of grpcChannelManager is currently an empty implementation, it would be better to use appendStartAndShutdown.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org