You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2022/11/18 19:28:58 UTC

[GitHub] [streampipes] flomickl opened a new pull request, #146: [Streampipes 584] Implementing Reprojection processor for Geo Coordinates via Apache SIS

flomickl opened a new pull request, #146:
URL: https://github.com/apache/streampipes/pull/146

   <!--
     ~ Licensed to the Apache Software Foundation (ASF) under one or more
     ~ contributor license agreements.  See the NOTICE file distributed with
     ~ this work for additional information regarding copyright ownership.
     ~ The ASF licenses this file to You under the Apache License, Version 2.0
     ~ (the "License"); you may not use this file except in compliance with
     ~ the License.  You may obtain a copy of the License at
     ~
     ~    http://www.apache.org/licenses/LICENSE-2.0
     ~
     ~ Unless required by applicable law or agreed to in writing, software
     ~ distributed under the License is distributed on an "AS IS" BASIS,
     ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     ~ See the License for the specific language governing permissions and
     ~ limitations under the License.
     ~
     -->
     
     <!--
   Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
   1. If this is your first time, please read our contributor guidelines:
       - https://streampipes.apache.org/getinvolved.html
       - https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
   2. Make sure the PR title is formatted like: `[STREAMPIPES-<Jira issue #>] PR title ...`
   3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][STREAMPIPES-<Jira issue #>] PR title ...`.
   4. Please write your PR title to summarize what this PR proposes/fixes.
   5. Be sure to keep the PR description updated to reflect all changes.
   6. If possible, provide a concise example to reproduce the issue for a faster review.
   7. Make sure tests pass via `mvn clean install`.
   8. (Optional) If the contribution is large, please file an Apache ICLA
       - http://apache.org/licenses/icla.pdf
   -->
   
   ### Purpose
   <!--
   Add Geo Processor for reproject geo coordinates.  Example from WGS84 to UTM32. This is a basic geo operation with geometries.
   -->
   
   ### Approach
   <!--
   added the functionality via Apache SIS. Supported Geometries are Points, LineStrings, Polygons and MultiPoints.
   Also validation checks are implemented for the use cases. DB Connection does not exist. An Invalid Version of the EPSG DB was installed. Also validation check of input field.
   -->
   
   ### Samples
   <!--
   Sample see description in ticket  https://issues.apache.org/jira/browse/STREAMPIPES-584 with an Pipeline Example and results from the data lake compared to reprojection in an external tool QGIS.
   -->
   
   ### Remarks
   <!--
   Still Open: Fallback and how to implement the docker-compose file.
   https://lists.apache.org/list?user@sis.apache.org:2022-8
   https://lists.apache.org/list?user@sis.apache.org:2022-10
   https://lists.apache.org/list?user@sis.apache.org:2022-11
   Internal:
   https://lists.apache.org/list?dev@streampipes.apache.org:2022-9
   
   Fallback Option in next ticket after merge.
   
   -->
   Fixes: [<Jira issue link>](https://issues.apache.org/jira/browse/STREAMPIPES-584)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] dominikriemer commented on a diff in pull request #146: [Streampipes 584] Implementing Reprojection processor for Geo Coordinates via Apache SIS

Posted by GitBox <gi...@apache.org>.
dominikriemer commented on code in PR #146:
URL: https://github.com/apache/streampipes/pull/146#discussion_r1027139815


##########
streampipes-extensions/streampipes-processors-geo-jvm/src/main/java/org/apache/streampipes/processors/geo/jvm/jts/processor/reprojection/ProjTransformationController.java:
##########
@@ -0,0 +1,75 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements.  See the NOTICE file distributed with
+ *   this work for additional information regarding copyright ownership.
+ *   The ASF licenses this file to You under the Apache License, Version 2.0
+ *   (the "License"); you may not use this file except in compliance with
+ *   the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+package org.apache.streampipes.processors.geo.jvm.jts.processor.reprojection;
+
+import org.apache.streampipes.model.DataProcessorType;
+import org.apache.streampipes.model.graph.DataProcessorDescription;
+import org.apache.streampipes.model.graph.DataProcessorInvocation;
+import org.apache.streampipes.model.schema.PropertyScope;
+import org.apache.streampipes.sdk.builder.ProcessingElementBuilder;
+import org.apache.streampipes.sdk.builder.StreamRequirementsBuilder;
+import org.apache.streampipes.sdk.extractor.ProcessingElementParameterExtractor;
+import org.apache.streampipes.sdk.helpers.EpRequirements;
+import org.apache.streampipes.sdk.helpers.Labels;
+import org.apache.streampipes.sdk.helpers.Locales;
+import org.apache.streampipes.sdk.helpers.OutputStrategies;
+import org.apache.streampipes.sdk.helpers.SupportedFormats;
+import org.apache.streampipes.sdk.helpers.SupportedProtocols;
+import org.apache.streampipes.sdk.utils.Assets;
+import org.apache.streampipes.wrapper.standalone.ConfiguredEventProcessor;
+import org.apache.streampipes.wrapper.standalone.declarer.StandaloneEventProcessingDeclarer;
+
+

Review Comment:
   @flomickl is it possible to migrate this processor to the 1-class processor model?
   As we try to migrate all processors over time...



##########
streampipes-extensions/streampipes-processors-geo-jvm/src/main/java/org/apache/streampipes/processors/geo/jvm/jts/processor/reprojection/ProjTransformation.java:
##########
@@ -0,0 +1,138 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements.  See the NOTICE file distributed with
+ *   this work for additional information regarding copyright ownership.
+ *   The ASF licenses this file to You under the Apache License, Version 2.0
+ *   (the "License"); you may not use this file except in compliance with
+ *   the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+package org.apache.streampipes.processors.geo.jvm.jts.processor.reprojection;
+
+import org.apache.streampipes.commons.exceptions.SpRuntimeException;
+import org.apache.streampipes.logging.api.Logger;
+import org.apache.streampipes.model.runtime.Event;
+import org.apache.streampipes.processors.geo.jvm.jts.exceptions.SpNotSupportedGeometryException;
+import org.apache.streampipes.processors.geo.jvm.jts.helper.SpGeometryBuilder;
+import org.apache.streampipes.processors.geo.jvm.jts.helper.SpReprojectionBuilder;
+import org.apache.streampipes.processors.geo.jvm.jts.processor.latLngToGeo.LatLngToGeoParameter;
+import org.apache.streampipes.wrapper.context.EventProcessorRuntimeContext;
+import org.apache.streampipes.wrapper.routing.SpOutputCollector;
+import org.apache.streampipes.wrapper.runtime.EventProcessor;
+
+import org.apache.sis.setup.Configuration;
+import org.locationtech.jts.geom.Geometry;
+import org.opengis.util.FactoryException;
+import org.postgresql.ds.PGSimpleDataSource;
+
+import javax.sql.DataSource;
+
+public class ProjTransformation implements EventProcessor<ProjTransformationParameter> {
+
+    private static Logger logger;
+    private ProjTransformationParameter params;
+    private Integer targetEPSG;
+
+    @Override
+    public void onInvocation(ProjTransformationParameter params, SpOutputCollector spOutputCollector,
+                             EventProcessorRuntimeContext runtimeContext) {
+        logger = params.getGraph().getLogger(LatLngToGeoParameter.class);
+        this.params = params;
+        targetEPSG = params.getTargetEpsg();
+
+        //TODO: this has to move to a central place in the streampipes backend
+        // otherwise Connection to SpatialMetadata database is already initialized occur
+
+        try {
+            Configuration.current().setDatabase(ProjTransformation::createDataSource);
+        } catch (IllegalStateException e) {
+            logger.info("Setup was already established");
+            // catch the exceptions due connection is already initialized.
+        }
+
+
+        // check if SIS DB is set up with imported data or is null
+        try {
+            if (SpReprojectionBuilder.isSisConfigurationValid()){
+                logger.info("SIS DB Settings successful checked ");
+            } else {
+                logger.warn("The required EPSG database is not imported");
+                //TODO implement fallback option with proj4j
+                throw new SpRuntimeException("Database not set and ready for fallback ");
+            }
+        } catch (FactoryException e) {
+            throw new SpRuntimeException("Something unexpected happened " + e);
+        }
+
+        // check if SIS DB has the supported 9.9.1 Version.
+        try {
+            if (!SpReprojectionBuilder.isSisDbCorrectVersion()) {
+                logger.warn("Not supported EPSG DB used.");
+                throw new SpRuntimeException("Your current EPSG DB version " + SpReprojectionBuilder.getSisDbVersion()
+                        + " is not the supported 9.9.1 version. ");
+            }
+        } catch (FactoryException e) {
+            throw new SpRuntimeException("Something unexpected happened " + e);
+        }
+
+        // checks if Input EPSG in valid and exists in EPSG DB
+        if (!SpReprojectionBuilder.isSisEpsgValid(targetEPSG)) {
+            throw new SpRuntimeException("Your chosen EPSG Code " + targetEPSG + " is not valid or supported. "
+                    + "Check EPSG on https://spatialreference.org");
+        }
+    }
+
+    @Override
+    public void onEvent(Event in, SpOutputCollector out) {
+
+        String wkt = in.getFieldBySelector(params.getWktString()).getAsPrimitive().getAsString();
+        Integer epsgCode = in.getFieldBySelector(params.getEpsgCode()).getAsPrimitive().getAsInt();
+        Geometry geometry = SpGeometryBuilder.createSPGeom(wkt, epsgCode);
+
+        Geometry transformed = null;
+        try {
+            transformed = SpReprojectionBuilder.reprojectSpGeometry(geometry, targetEPSG);
+        } catch (SpNotSupportedGeometryException e) {
+            transformed = SpGeometryBuilder.createEmptyGeometry(geometry);
+        }
+
+        if (!transformed.isEmpty()) {
+            in.updateFieldBySelector("s0::" + ProjTransformationController.EPSG_RUNTIME, params.getTargetEpsg());
+            in.updateFieldBySelector("s0::" + ProjTransformationController.WKT_RUNTIME, transformed.toText());
+
+            out.collect(in);
+        } else {
+            logger.warn("An empty point geometry is created in " + ProjTransformationController.EPA_NAME + " " +
+                    "due invalid input values. Check used epsg Code:" + epsgCode);
+        }
+    }
+
+    @Override
+    public void onDetach() {
+    }
+
+    // https://sis.apache.org/apidocs/org/apache/sis/setup/Configuration.html#setDatabase(java.util.function.Supplier)
+    // TODO: Best would be ConfigKeys VARIABLE. ATM hardcoded and adjustments for development required like IP of client
+    // TODO: has to move together with the Configuration.current() method
+    protected static DataSource createDataSource() {
+        PGSimpleDataSource ds = new PGSimpleDataSource();
+        // HAS TO BE ADJUSTED OR INCLUDED IN THE AUTO_DISCOVERY
+        String[] serverAddresses = {"192.168.178.100"};

Review Comment:
   Can we replace this internal IP with an environment variable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] bossenti commented on pull request #146: [Streampipes 584] Implementing Reprojection processor for Geo Coordinates via Apache SIS

Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #146:
URL: https://github.com/apache/streampipes/pull/146#issuecomment-1320823285

   @flomickl I just rebased your PR to have it aligned with the current state of the dev branch. As I just created the PR for STREAMPIPES-590, I added the Apache header to your `strings.en` file as well. Hope this is fine! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] bossenti commented on pull request #146: [Streampipes 584] Implementing Reprojection processor for Geo Coordinates via Apache SIS

Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #146:
URL: https://github.com/apache/streampipes/pull/146#issuecomment-1327519965

   @flomickl I just rebased your branch again so it is up to date with `dev`.
   The tests added by @dominikriemer that were gone are now there again.
   Since we have a lot of commits on this branch now, it would be great if you use the option `squash and merge` when merging this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] flomickl commented on a diff in pull request #146: [Streampipes 584] Implementing Reprojection processor for Geo Coordinates via Apache SIS

Posted by GitBox <gi...@apache.org>.
flomickl commented on code in PR #146:
URL: https://github.com/apache/streampipes/pull/146#discussion_r1027325725


##########
streampipes-extensions/streampipes-processors-geo-jvm/src/main/java/org/apache/streampipes/processors/geo/jvm/jts/processor/reprojection/ProjTransformationController.java:
##########
@@ -0,0 +1,75 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements.  See the NOTICE file distributed with
+ *   this work for additional information regarding copyright ownership.
+ *   The ASF licenses this file to You under the Apache License, Version 2.0
+ *   (the "License"); you may not use this file except in compliance with
+ *   the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+package org.apache.streampipes.processors.geo.jvm.jts.processor.reprojection;
+
+import org.apache.streampipes.model.DataProcessorType;
+import org.apache.streampipes.model.graph.DataProcessorDescription;
+import org.apache.streampipes.model.graph.DataProcessorInvocation;
+import org.apache.streampipes.model.schema.PropertyScope;
+import org.apache.streampipes.sdk.builder.ProcessingElementBuilder;
+import org.apache.streampipes.sdk.builder.StreamRequirementsBuilder;
+import org.apache.streampipes.sdk.extractor.ProcessingElementParameterExtractor;
+import org.apache.streampipes.sdk.helpers.EpRequirements;
+import org.apache.streampipes.sdk.helpers.Labels;
+import org.apache.streampipes.sdk.helpers.Locales;
+import org.apache.streampipes.sdk.helpers.OutputStrategies;
+import org.apache.streampipes.sdk.helpers.SupportedFormats;
+import org.apache.streampipes.sdk.helpers.SupportedProtocols;
+import org.apache.streampipes.sdk.utils.Assets;
+import org.apache.streampipes.wrapper.standalone.ConfiguredEventProcessor;
+import org.apache.streampipes.wrapper.standalone.declarer.StandaloneEventProcessingDeclarer;
+
+

Review Comment:
   yep I can do that and commit it in this branche



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] flomickl closed pull request #146: [Streampipes 584] Implementing Reprojection processor for Geo Coordinates via Apache SIS

Posted by GitBox <gi...@apache.org>.
flomickl closed pull request #146: [Streampipes 584] Implementing  Reprojection processor for Geo Coordinates via Apache SIS
URL: https://github.com/apache/streampipes/pull/146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] flomickl commented on pull request #146: [Streampipes 584] Implementing Reprojection processor for Geo Coordinates via Apache SIS

Posted by GitBox <gi...@apache.org>.
flomickl commented on PR #146:
URL: https://github.com/apache/streampipes/pull/146#issuecomment-1324107088

   1 class structure resolved. Also added docker-compose file.
   Only one open question is left.
   Atm the  deploy/standalone/epsg/scripts folder  is not found during CLI start. So what is the base path from the docker-compose execution point? 
   Readme in progress


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] flomickl commented on a diff in pull request #146: [Streampipes 584] Implementing Reprojection processor for Geo Coordinates via Apache SIS

Posted by GitBox <gi...@apache.org>.
flomickl commented on code in PR #146:
URL: https://github.com/apache/streampipes/pull/146#discussion_r1027325623


##########
streampipes-extensions/streampipes-processors-geo-jvm/src/main/java/org/apache/streampipes/processors/geo/jvm/jts/processor/reprojection/ProjTransformation.java:
##########
@@ -0,0 +1,138 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements.  See the NOTICE file distributed with
+ *   this work for additional information regarding copyright ownership.
+ *   The ASF licenses this file to You under the Apache License, Version 2.0
+ *   (the "License"); you may not use this file except in compliance with
+ *   the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+package org.apache.streampipes.processors.geo.jvm.jts.processor.reprojection;
+
+import org.apache.streampipes.commons.exceptions.SpRuntimeException;
+import org.apache.streampipes.logging.api.Logger;
+import org.apache.streampipes.model.runtime.Event;
+import org.apache.streampipes.processors.geo.jvm.jts.exceptions.SpNotSupportedGeometryException;
+import org.apache.streampipes.processors.geo.jvm.jts.helper.SpGeometryBuilder;
+import org.apache.streampipes.processors.geo.jvm.jts.helper.SpReprojectionBuilder;
+import org.apache.streampipes.processors.geo.jvm.jts.processor.latLngToGeo.LatLngToGeoParameter;
+import org.apache.streampipes.wrapper.context.EventProcessorRuntimeContext;
+import org.apache.streampipes.wrapper.routing.SpOutputCollector;
+import org.apache.streampipes.wrapper.runtime.EventProcessor;
+
+import org.apache.sis.setup.Configuration;
+import org.locationtech.jts.geom.Geometry;
+import org.opengis.util.FactoryException;
+import org.postgresql.ds.PGSimpleDataSource;
+
+import javax.sql.DataSource;
+
+public class ProjTransformation implements EventProcessor<ProjTransformationParameter> {
+
+    private static Logger logger;
+    private ProjTransformationParameter params;
+    private Integer targetEPSG;
+
+    @Override
+    public void onInvocation(ProjTransformationParameter params, SpOutputCollector spOutputCollector,
+                             EventProcessorRuntimeContext runtimeContext) {
+        logger = params.getGraph().getLogger(LatLngToGeoParameter.class);
+        this.params = params;
+        targetEPSG = params.getTargetEpsg();
+
+        //TODO: this has to move to a central place in the streampipes backend
+        // otherwise Connection to SpatialMetadata database is already initialized occur
+
+        try {
+            Configuration.current().setDatabase(ProjTransformation::createDataSource);
+        } catch (IllegalStateException e) {
+            logger.info("Setup was already established");
+            // catch the exceptions due connection is already initialized.
+        }
+
+
+        // check if SIS DB is set up with imported data or is null
+        try {
+            if (SpReprojectionBuilder.isSisConfigurationValid()){
+                logger.info("SIS DB Settings successful checked ");
+            } else {
+                logger.warn("The required EPSG database is not imported");
+                //TODO implement fallback option with proj4j
+                throw new SpRuntimeException("Database not set and ready for fallback ");
+            }
+        } catch (FactoryException e) {
+            throw new SpRuntimeException("Something unexpected happened " + e);
+        }
+
+        // check if SIS DB has the supported 9.9.1 Version.
+        try {
+            if (!SpReprojectionBuilder.isSisDbCorrectVersion()) {
+                logger.warn("Not supported EPSG DB used.");
+                throw new SpRuntimeException("Your current EPSG DB version " + SpReprojectionBuilder.getSisDbVersion()
+                        + " is not the supported 9.9.1 version. ");
+            }
+        } catch (FactoryException e) {
+            throw new SpRuntimeException("Something unexpected happened " + e);
+        }
+
+        // checks if Input EPSG in valid and exists in EPSG DB
+        if (!SpReprojectionBuilder.isSisEpsgValid(targetEPSG)) {
+            throw new SpRuntimeException("Your chosen EPSG Code " + targetEPSG + " is not valid or supported. "
+                    + "Check EPSG on https://spatialreference.org");
+        }
+    }
+
+    @Override
+    public void onEvent(Event in, SpOutputCollector out) {
+
+        String wkt = in.getFieldBySelector(params.getWktString()).getAsPrimitive().getAsString();
+        Integer epsgCode = in.getFieldBySelector(params.getEpsgCode()).getAsPrimitive().getAsInt();
+        Geometry geometry = SpGeometryBuilder.createSPGeom(wkt, epsgCode);
+
+        Geometry transformed = null;
+        try {
+            transformed = SpReprojectionBuilder.reprojectSpGeometry(geometry, targetEPSG);
+        } catch (SpNotSupportedGeometryException e) {
+            transformed = SpGeometryBuilder.createEmptyGeometry(geometry);
+        }
+
+        if (!transformed.isEmpty()) {
+            in.updateFieldBySelector("s0::" + ProjTransformationController.EPSG_RUNTIME, params.getTargetEpsg());
+            in.updateFieldBySelector("s0::" + ProjTransformationController.WKT_RUNTIME, transformed.toText());
+
+            out.collect(in);
+        } else {
+            logger.warn("An empty point geometry is created in " + ProjTransformationController.EPA_NAME + " " +
+                    "due invalid input values. Check used epsg Code:" + epsgCode);
+        }
+    }
+
+    @Override
+    public void onDetach() {
+    }
+
+    // https://sis.apache.org/apidocs/org/apache/sis/setup/Configuration.html#setDatabase(java.util.function.Supplier)
+    // TODO: Best would be ConfigKeys VARIABLE. ATM hardcoded and adjustments for development required like IP of client
+    // TODO: has to move together with the Configuration.current() method
+    protected static DataSource createDataSource() {
+        PGSimpleDataSource ds = new PGSimpleDataSource();
+        // HAS TO BE ADJUSTED OR INCLUDED IN THE AUTO_DISCOVERY
+        String[] serverAddresses = {"192.168.178.100"};

Review Comment:
   Can you show me an example with the consul variables please?
   BTW is it save to put this and the cretaConenction in the GeoJvmInit ?
   
   This  method  just has to be called  ones during "start"
   So it can be used by all processors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org