You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2021/03/01 17:04:08 UTC
[kudu] branch master updated: [multi-master-test] fix compilation
warning
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new 9c0cd1a [multi-master-test] fix compilation warning
9c0cd1a is described below
commit 9c0cd1a6b4a3a35040b0cd4f5e9524cdb855d059
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Fri Feb 26 23:08:32 2021 -0800
[multi-master-test] fix compilation warning
Replaced INSTANTIATE_TEST_CASE_P with INSTANTIATE_TEST_SUITE_P
in dynamic_multi_master-test.cc to address compilation warning:
src/kudu/master/dynamic_multi_master-test.cc:833:1: \
warning: 'InstantiateTestCase_P_IsDeprecated' is deprecated: \
INSTANTIATE_TEST_CASE_P is deprecated, please use \
INSTANTIATE_TEST_SUITE_P [-Wdeprecated-declarations]
Change-Id: Ibc2507082e57ada9aea1bdaa7fb0eb11c5e2ced2
Reviewed-on: http://gerrit.cloudera.org:8080/17133
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
src/kudu/master/dynamic_multi_master-test.cc | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/kudu/master/dynamic_multi_master-test.cc b/src/kudu/master/dynamic_multi_master-test.cc
index cdf3a07..7b0eed4 100644
--- a/src/kudu/master/dynamic_multi_master-test.cc
+++ b/src/kudu/master/dynamic_multi_master-test.cc
@@ -830,12 +830,12 @@ class ParameterizedRemoveMasterTest : public DynamicMultiMasterTest,
}
};
-INSTANTIATE_TEST_CASE_P(, ParameterizedRemoveMasterTest,
- ::testing::Combine(
- // Initial number of masters in the cluster before removing a master
- ::testing::Values(2, 3),
- // Whether the master to be removed is dead/shutdown
- ::testing::Bool()));
+INSTANTIATE_TEST_SUITE_P(, ParameterizedRemoveMasterTest,
+ ::testing::Combine(
+ // Initial number of masters in the cluster before removing a master
+ ::testing::Values(2, 3),
+ // Whether the master to be removed is dead/shutdown
+ ::testing::Bool()));
// Tests removing a non-leader master from the cluster.
TEST_P(ParameterizedRemoveMasterTest, TestRemoveMaster) {
@@ -1206,7 +1206,8 @@ class ParameterizedRemoveLeaderMasterTest : public DynamicMultiMasterTest,
}
};
-INSTANTIATE_TEST_CASE_P(, ParameterizedRemoveLeaderMasterTest, ::testing::Values(1, 2));
+INSTANTIATE_TEST_SUITE_P(, ParameterizedRemoveLeaderMasterTest,
+ ::testing::Values(1, 2));
TEST_P(ParameterizedRemoveLeaderMasterTest, TestRemoveLeaderMaster) {
NO_FATALS(StartCluster({"--master_support_change_config"}));