You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by "cdmikechen (via GitHub)" <gi...@apache.org> on 2023/09/23 11:11:46 UTC

[GitHub] [submarine] cdmikechen opened a new pull request, #1106: SUBMARINE-1410. Update website node to 18

cdmikechen opened a new pull request, #1106:
URL: https://github.com/apache/submarine/pull/1106

   ### What is this PR for?
   Update website node to 18(lts)
   
   ### What type of PR is it?
   Documentation
   
   ### Todos
   * [x] - Set node to 18 in git workflow
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-1410
   
   ### How should this be tested?
   CI 
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [submarine] codecov[bot] commented on pull request #1106: SUBMARINE-1410. Update website node to 18

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1106:
URL: https://github.com/apache/submarine/pull/1106#issuecomment-1732285333

   ## [Codecov](https://app.codecov.io/gh/apache/submarine/pull/1106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#1106](https://app.codecov.io/gh/apache/submarine/pull/1106?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (69cdb1a) into [master](https://app.codecov.io/gh/apache/submarine/commit/6ed412edd95afddcdd327d4b389b214d592cdc45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6ed412e) will **decrease** coverage by `13.40%`.
   > Report is 1 commits behind head on master.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #1106       +/-   ##
   ===========================================
   - Coverage   53.97%   40.57%   -13.40%     
   ===========================================
     Files         130      130               
     Lines        6320     5971      -349     
   ===========================================
   - Hits         3411     2423      -988     
   - Misses       2909     3548      +639     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/submarine/pull/1106/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [python-integration](https://app.codecov.io/gh/apache/submarine/pull/1106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [python-unit](https://app.codecov.io/gh/apache/submarine/pull/1106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.57% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 84 files with indirect coverage changes](https://app.codecov.io/gh/apache/submarine/pull/1106/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SUBMARINE-1410. Update website node to 18 [submarine]

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #1106: SUBMARINE-1410. Update website node to 18
URL: https://github.com/apache/submarine/pull/1106


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org