You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/04/06 22:43:31 UTC

[jira] Created: (HARMONY-319) BigDecimal and Biginteger test failures should be fixed

BigDecimal and Biginteger test failures should be fixed
-------------------------------------------------------

         Key: HARMONY-319
         URL: http://issues.apache.org/jira/browse/HARMONY-319
     Project: Harmony
        Type: Bug

  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Minor


The original API tests from BigInteger and BigDecimal from the IBM implementation fail on the new Intel implementation.  See the too exclusions in modules/math/make/common/build.xml :

    <!-- This test seems to loop -->
    <exclude name="**/api/java/math/BigDecimalTest.java" />
    <!-- This test fails -->
    <exclude name="**/api/java/math/BigIntegerTest.java" />

I commented on this when I attached the integration scripts/diffs but no one seems to have picked up on it so I thought I'd better raise a JIRA to make sure it wasn't overlooked.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Resolved: (HARMONY-319) BigDecimal and Biginteger test failures should be fixed

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-319?page=all ]
     
Mikhail Loenko resolved HARMONY-319:
------------------------------------

    Resolution: Fixed

fixed in revision 397091
Sian, please check that it fully resolves the problem

> BigDecimal and Biginteger test failures should be fixed
> -------------------------------------------------------
>
>          Key: HARMONY-319
>          URL: http://issues.apache.org/jira/browse/HARMONY-319
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: mathpatch.txt, mathpatch2.txt
>
> The original API tests from BigInteger and BigDecimal from the IBM implementation fail on the new Intel implementation.  See the too exclusions in modules/math/make/common/build.xml :
>     <!-- This test seems to loop -->
>     <exclude name="**/api/java/math/BigDecimalTest.java" />
>     <!-- This test fails -->
>     <exclude name="**/api/java/math/BigIntegerTest.java" />
> I commented on this when I attached the integration scripts/diffs but no one seems to have picked up on it so I thought I'd better raise a JIRA to make sure it wasn't overlooked.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (HARMONY-319) BigDecimal and Biginteger test failures should be fixed

Posted by "Sian January (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-319?page=all ]

Sian January updated HARMONY-319:
---------------------------------

    Attachment: mathpatch2.txt

I have updated the patch so that all the math tests now pass.

> BigDecimal and Biginteger test failures should be fixed
> -------------------------------------------------------
>
>          Key: HARMONY-319
>          URL: http://issues.apache.org/jira/browse/HARMONY-319
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: mathpatch.txt, mathpatch2.txt
>
> The original API tests from BigInteger and BigDecimal from the IBM implementation fail on the new Intel implementation.  See the too exclusions in modules/math/make/common/build.xml :
>     <!-- This test seems to loop -->
>     <exclude name="**/api/java/math/BigDecimalTest.java" />
>     <!-- This test fails -->
>     <exclude name="**/api/java/math/BigIntegerTest.java" />
> I commented on this when I attached the integration scripts/diffs but no one seems to have picked up on it so I thought I'd better raise a JIRA to make sure it wasn't overlooked.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Assigned: (HARMONY-319) BigDecimal and Biginteger test failures should be fixed

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-319?page=all ]

Mikhail Loenko reassigned HARMONY-319:
--------------------------------------

    Assign To: Mikhail Loenko

> BigDecimal and Biginteger test failures should be fixed
> -------------------------------------------------------
>
>          Key: HARMONY-319
>          URL: http://issues.apache.org/jira/browse/HARMONY-319
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: mathpatch.txt
>
> The original API tests from BigInteger and BigDecimal from the IBM implementation fail on the new Intel implementation.  See the too exclusions in modules/math/make/common/build.xml :
>     <!-- This test seems to loop -->
>     <exclude name="**/api/java/math/BigDecimalTest.java" />
>     <!-- This test fails -->
>     <exclude name="**/api/java/math/BigIntegerTest.java" />
> I commented on this when I attached the integration scripts/diffs but no one seems to have picked up on it so I thought I'd better raise a JIRA to make sure it wasn't overlooked.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (HARMONY-319) BigDecimal and Biginteger test failures should be fixed

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-319?page=comments#action_12376185 ] 

Mikhail Loenko commented on HARMONY-319:
----------------------------------------

fixes in the tests applied in revision 396803
the tests now pass on RI

fixes to the code were not applied as they cause failures of other math tests

> BigDecimal and Biginteger test failures should be fixed
> -------------------------------------------------------
>
>          Key: HARMONY-319
>          URL: http://issues.apache.org/jira/browse/HARMONY-319
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: mathpatch.txt
>
> The original API tests from BigInteger and BigDecimal from the IBM implementation fail on the new Intel implementation.  See the too exclusions in modules/math/make/common/build.xml :
>     <!-- This test seems to loop -->
>     <exclude name="**/api/java/math/BigDecimalTest.java" />
>     <!-- This test fails -->
>     <exclude name="**/api/java/math/BigIntegerTest.java" />
> I commented on this when I attached the integration scripts/diffs but no one seems to have picked up on it so I thought I'd better raise a JIRA to make sure it wasn't overlooked.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (HARMONY-319) BigDecimal and Biginteger test failures should be fixed

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-319?page=all ]
     
Mikhail Loenko closed HARMONY-319:
----------------------------------


verified by Sian

> BigDecimal and Biginteger test failures should be fixed
> -------------------------------------------------------
>
>          Key: HARMONY-319
>          URL: http://issues.apache.org/jira/browse/HARMONY-319
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: mathpatch.txt, mathpatch2.txt
>
> The original API tests from BigInteger and BigDecimal from the IBM implementation fail on the new Intel implementation.  See the too exclusions in modules/math/make/common/build.xml :
>     <!-- This test seems to loop -->
>     <exclude name="**/api/java/math/BigDecimalTest.java" />
>     <!-- This test fails -->
>     <exclude name="**/api/java/math/BigIntegerTest.java" />
> I commented on this when I attached the integration scripts/diffs but no one seems to have picked up on it so I thought I'd better raise a JIRA to make sure it wasn't overlooked.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (HARMONY-319) BigDecimal and Biginteger test failures should be fixed

Posted by "Sian January (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-319?page=all ]

Sian January updated HARMONY-319:
---------------------------------

    Attachment: mathpatch.txt

I have opened a separate bug to track the endless loop problem, which is actually related to the Double class (see HARMONY-329).  This patch fixes all the other problems seen for BigDecimal and BigInteger.  The patch includes some test changes as well as some changes to BigDecimal and BigInteger because some of the tests were testing for the wrong thing, and were also failing on both IBM's and Sun's 1.5.0 implementations.  

I also found another problem with BigDecimal, where calling 'new BigDecimal("")' should throw a NumberFormatException and was instead throwing a StringIndexOutOfBoundsException.  I added test test_constructor_String_empty for this.

In the patch I have commented out the call that caused the endless loop (in BigDecimalTest.test_doubleValue()) so that the tests could be added back in to the suite if desired.

The patch should be applied to the modules directory.

> BigDecimal and Biginteger test failures should be fixed
> -------------------------------------------------------
>
>          Key: HARMONY-319
>          URL: http://issues.apache.org/jira/browse/HARMONY-319
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Minor
>  Attachments: mathpatch.txt
>
> The original API tests from BigInteger and BigDecimal from the IBM implementation fail on the new Intel implementation.  See the too exclusions in modules/math/make/common/build.xml :
>     <!-- This test seems to loop -->
>     <exclude name="**/api/java/math/BigDecimalTest.java" />
>     <!-- This test fails -->
>     <exclude name="**/api/java/math/BigIntegerTest.java" />
> I commented on this when I attached the integration scripts/diffs but no one seems to have picked up on it so I thought I'd better raise a JIRA to make sure it wasn't overlooked.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (HARMONY-319) BigDecimal and Biginteger test failures should be fixed

Posted by "Sian January (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-319?page=comments#action_12376692 ] 

Sian January commented on HARMONY-319:
--------------------------------------

Thanks Mikhail - that looks great.

> BigDecimal and Biginteger test failures should be fixed
> -------------------------------------------------------
>
>          Key: HARMONY-319
>          URL: http://issues.apache.org/jira/browse/HARMONY-319
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Minor
>  Attachments: mathpatch.txt, mathpatch2.txt
>
> The original API tests from BigInteger and BigDecimal from the IBM implementation fail on the new Intel implementation.  See the too exclusions in modules/math/make/common/build.xml :
>     <!-- This test seems to loop -->
>     <exclude name="**/api/java/math/BigDecimalTest.java" />
>     <!-- This test fails -->
>     <exclude name="**/api/java/math/BigIntegerTest.java" />
> I commented on this when I attached the integration scripts/diffs but no one seems to have picked up on it so I thought I'd better raise a JIRA to make sure it wasn't overlooked.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira