You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/04/21 23:48:16 UTC
Review Request 33415: Changed launchers and isolators to adapt to the
new orphan cleanup semantics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33415/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Bugs: MESOS-2367
https://issues.apache.org/jira/browse/MESOS-2367
Repository: mesos
Description
-------
Changed launchers and isolators to adapt to the new orphan cleanup semantics.
See my description in https://reviews.apache.org/r/33413/.
Diffs
-----
src/slave/containerizer/isolators/cgroups/cpushare.cpp 41b2597098a81baffae19fa91d6c9a86cf60d429
src/slave/containerizer/isolators/cgroups/mem.cpp a7a83ef9ad4726aa139a92fc7f5917ed687d33f5
src/slave/containerizer/isolators/cgroups/perf_event.cpp 4dfccc51035b234c31a9f73ca67b3bf0fd28441b
src/slave/containerizer/isolators/namespaces/pid.cpp eb35ae6e34fa46dd38c9a96e69d38a229b3678d3
src/slave/containerizer/isolators/network/port_mapping.cpp ccdc44f465f204f674b859c429ba1a6ada51cd88
src/slave/containerizer/linux_launcher.hpp 60082c7eb8b77330911ac4fa38cc9ba795fc4051
src/slave/containerizer/linux_launcher.cpp b176ac126657ed8291dd817ceb61c04a68ff1d42
src/slave/containerizer/mesos/containerizer.hpp ae61a0fcd19f2ba808624312401f020121baf5d4
src/tests/port_mapping_tests.cpp 36219e737c75a5942dfc206c10997d5bcaf619fe
Diff: https://reviews.apache.org/r/33415/diff/
Testing
-------
sudo make check
The new code is exercised by the exiting test: PortMappingMesosTest.ROOT_CleanUpOrphanTest
Thanks,
Jie Yu
Re: Review Request 33415: Changed launchers and isolators to adapt to
the new orphan cleanup semantics.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33415/#review81079
-----------------------------------------------------------
Bad patch!
Reviews applied: [33412, 33413, 33414]
Failed command: ./support/apply-review.sh -n -r 33414
Error:
2015-04-21 22:30:40 URL:https://reviews.apache.org/r/33414/diff/raw/ [8143/8143] -> "33414.patch" [1]
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:1026
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On April 21, 2015, 9:48 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33415/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 9:48 p.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2367
> https://issues.apache.org/jira/browse/MESOS-2367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed launchers and isolators to adapt to the new orphan cleanup semantics.
>
> See my description in https://reviews.apache.org/r/33413/.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 41b2597098a81baffae19fa91d6c9a86cf60d429
> src/slave/containerizer/isolators/cgroups/mem.cpp a7a83ef9ad4726aa139a92fc7f5917ed687d33f5
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 4dfccc51035b234c31a9f73ca67b3bf0fd28441b
> src/slave/containerizer/isolators/namespaces/pid.cpp eb35ae6e34fa46dd38c9a96e69d38a229b3678d3
> src/slave/containerizer/isolators/network/port_mapping.cpp ccdc44f465f204f674b859c429ba1a6ada51cd88
> src/slave/containerizer/linux_launcher.hpp 60082c7eb8b77330911ac4fa38cc9ba795fc4051
> src/slave/containerizer/linux_launcher.cpp b176ac126657ed8291dd817ceb61c04a68ff1d42
> src/slave/containerizer/mesos/containerizer.hpp ae61a0fcd19f2ba808624312401f020121baf5d4
> src/tests/port_mapping_tests.cpp 36219e737c75a5942dfc206c10997d5bcaf619fe
>
> Diff: https://reviews.apache.org/r/33415/diff/
>
>
> Testing
> -------
>
> sudo make check
>
> The new code is exercised by the exiting test: PortMappingMesosTest.ROOT_CleanUpOrphanTest
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 33415: Changed launchers and isolators to adapt to
the new orphan cleanup semantics.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33415/#review81526
-----------------------------------------------------------
Ship it!
src/slave/containerizer/isolators/namespaces/pid.cpp
<https://reviews.apache.org/r/33415/#comment131938>
Have we changed from preferring const char[]?
src/slave/containerizer/isolators/namespaces/pid.cpp
<https://reviews.apache.org/r/33415/#comment131939>
ditto
src/slave/containerizer/linux_launcher.cpp
<https://reviews.apache.org/r/33415/#comment131914>
static?
src/slave/containerizer/linux_launcher.cpp
<https://reviews.apache.org/r/33415/#comment131915>
CHECK_SOME on os::basename?
- Ian Downes
On April 21, 2015, 2:48 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33415/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 2:48 p.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2367
> https://issues.apache.org/jira/browse/MESOS-2367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed launchers and isolators to adapt to the new orphan cleanup semantics.
>
> See my description in https://reviews.apache.org/r/33413/.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 41b2597098a81baffae19fa91d6c9a86cf60d429
> src/slave/containerizer/isolators/cgroups/mem.cpp a7a83ef9ad4726aa139a92fc7f5917ed687d33f5
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 4dfccc51035b234c31a9f73ca67b3bf0fd28441b
> src/slave/containerizer/isolators/namespaces/pid.cpp eb35ae6e34fa46dd38c9a96e69d38a229b3678d3
> src/slave/containerizer/isolators/network/port_mapping.cpp ccdc44f465f204f674b859c429ba1a6ada51cd88
> src/slave/containerizer/linux_launcher.hpp 60082c7eb8b77330911ac4fa38cc9ba795fc4051
> src/slave/containerizer/linux_launcher.cpp b176ac126657ed8291dd817ceb61c04a68ff1d42
> src/slave/containerizer/mesos/containerizer.hpp ae61a0fcd19f2ba808624312401f020121baf5d4
> src/tests/port_mapping_tests.cpp 36219e737c75a5942dfc206c10997d5bcaf619fe
>
> Diff: https://reviews.apache.org/r/33415/diff/
>
>
> Testing
> -------
>
> sudo make check
>
> The new code is exercised by the exiting test: PortMappingMesosTest.ROOT_CleanUpOrphanTest
>
>
> Thanks,
>
> Jie Yu
>
>