You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/11 06:01:34 UTC

[GitHub] [skywalking] heihei180 opened a new pull request, #9948: modify doc changes.md

heihei180 opened a new pull request, #9948:
URL: https://github.com/apache/skywalking/pull/9948

   modify doc changes.md , link: https://github.com/apache/skywalking/pull/9915


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng merged pull request #9948: modify doc changes.md

Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9948:
URL: https://github.com/apache/skywalking/pull/9948


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #9948: modify doc changes.md

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9948:
URL: https://github.com/apache/skywalking/pull/9948#issuecomment-1311313989

   What's done? Did you forget or fail to push the update?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] heihei180 commented on pull request #9948: modify doc changes.md

Posted by GitBox <gi...@apache.org>.
heihei180 commented on PR #9948:
URL: https://github.com/apache/skywalking/pull/9948#issuecomment-1311312944

   > Please make your commit log clear. This is so long. And the change log should be only about, your added component ID(s). There is nothing about the Java plugin
   
   done 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9948: modify doc changes.md

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9948:
URL: https://github.com/apache/skywalking/pull/9948#discussion_r1019965547


##########
docs/en/changes/changes.md:
##########
@@ -4,6 +4,9 @@
 
 * Bump up the embedded `swctl` version in OAP Docker image.
 
+#### Java Agent
+* Add `eventmesh-1.x` plugin
+

Review Comment:
   ```suggestion
   ```
   
   This isn't main repo change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #9948: modify doc changes.md

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9948:
URL: https://github.com/apache/skywalking/pull/9948#issuecomment-1311277264

   Please make your commit log clear. This is so long. And the change log should be only about, your added component ID(s). There is nothing about the Java plugin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] heihei180 commented on pull request #9948: modify doc changes.md

Posted by GitBox <gi...@apache.org>.
heihei180 commented on PR #9948:
URL: https://github.com/apache/skywalking/pull/9948#issuecomment-1311365623

   > I made the change log for you. Please be more careful to process documents. The codes are not the only thing that matter.
   
   Thank you very much for your guidance!!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org