[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6694: NIFI-10852 allows commons-compress to use groupid large groupid values

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6694:
URL: https://github.com/apache/nifi/pull/6694#discussion_r1028450214


##########
c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/operation/TransferDebugOperationHandler.java:
##########
@@ -178,6 +178,7 @@ private Optional<byte[]> createDebugBundle(List<Path> filePaths) {
         try (GzipCompressorOutputStream gzipCompressorOutputStream = new GzipCompressorOutputStream(byteOutputStream);
              TarArchiveOutputStream tarOutputStream = new TarArchiveOutputStream(gzipCompressorOutputStream)) {
             for (Path filePath : filePaths) {
+                tarOutputStream.setBigNumberMode(1);

Review Comment:
   Can you change this to `TarArchiveOutputStream.BIGNUMBER_POSIX`? The value of `1` is equivalent to `BIGNUMBER_STAR`, which does not appear to be as widely supported according to the [commons-compress documentation](https://commons.apache.org/proper/commons-compress/tar.html).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org