[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6049: Flink: Add Sink options to override the compression properties of the Table

[GitBox <gi...@apache.org>]

stevenzwu commented on code in PR #6049:
URL: https://github.com/apache/iceberg/pull/6049#discussion_r1004684887


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkConfParser.java:
##########
@@ -139,7 +139,6 @@ public StringConfParser defaultValue(String value) {
     }
 
     public String parse() {
-      Preconditions.checkArgument(defaultValue != null, "Default value cannot be null");

Review Comment:
   why do we remove this line? My understanding of code is that `parseOptional` should be used if default can be null



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org