You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sha174n (via GitHub)" <gi...@apache.org> on 2026/10/22 14:52:42 UTC
[PR] fix(datasets): validate metric d3format [superset]
sha174n opened a new pull request, #45633:
URL: https://github.com/apache/superset/pull/45633
### SUMMARY
A dataset metric's `d3format` was accepted as any string within the length limit. This adds server-side validation so the API only accepts a valid d3-format specifier or one of the named number formats the frontend recognises, rejecting anything else.
A single predicate (`is_valid_d3_format` in `superset/utils/number_format.py`) backs the dataset PUT metric schema, the v1 import metric schema, and the MCP dataset-metric schemas. The named-format allowlist is kept in one constant, sourced from the frontend formatter registry (`setupFormatters.ts`, `NumberFormats.ts`, `D3_FORMAT_OPTIONS`). No model change or migration.
### TESTING INSTRUCTIONS
Added unit tests for the validator and the dataset metric schemas (valid specifiers, named formats, invalid strings, over-length, and the offending-metric index), plus a dataset API test that an invalid format is rejected and nothing is stored. Existing `number_format` tests continue to pass.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime consequences of this change
๐ค Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(datasets): validate metric d3format [superset]
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez merged PR #45633:
URL: https://github.com/apache/superset/pull/45633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(datasets): validate metric d3format [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45633:
URL: https://github.com/apache/superset/pull/45633#issuecomment-6344016700
## CodeAnt PR Risk: Medium Risk
- The PR needs attention before merging.
- Import and MCP dataset schemas accept formats longer than the 128-character column limit, risking bundle or virtual-dataset persistence failures.
**Assessed commit:** `8192be6be6cf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(datasets): validate metric d3format [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45633:
URL: https://github.com/apache/superset/pull/45633#issuecomment-6345511021
### <span aria-hidden="true">โ
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">๐จ</span> Latest commit | 7a48b780113e1d53a9f33a5980ebefb96e8e1c6f |
|<span aria-hidden="true">๐</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ada3581d747fc6aa8d4d7c7 |
|<span aria-hidden="true">๐</span> Deploy Preview | [https://deploy-preview-45633--superset-docs-preview.netlify.app](https://deploy-preview-45633--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">๐ฑ</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">๐ค</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctRCoAgEEXRvcx3ElFptIOW8XKUhEyxIYpo7_l34XJeyiXFLDQTNbQWHHar7cPdMgSnExWdlGAV9z6VCFEX9lBfSEcV7PKenoWr0WD049SxGYy3Gph4YGMNfT8) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-45633--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(datasets): validate metric d3format [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #45633:
URL: https://github.com/apache/superset/pull/45633#discussion_r4349978823
##########
superset/datasets/schemas.py:
##########
@@ -421,7 +434,7 @@ def fix_template_params(
metric_type = fields.String(allow_none=True)
expression = fields.String(required=True)
description = fields.String(allow_none=True)
- d3format = fields.String(allow_none=True)
+ d3format = fields.String(allow_none=True, validate=validate_d3format)
Review Comment:
**Suggestion:** This import schema checks only syntax, so a valid-looking value longer than the model's 128-character column passes validation and can make bundle persistence fail.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incomplete implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b21dc6930b814d16863180ce9d49cbdd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b21dc6930b814d16863180ce9d49cbdd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/datasets/schemas.py
**Line:** 437:437
**Comment:**
*Incomplete Implementation: This import schema checks only syntax, so a valid-looking value longer than the model's 128-character column passes validation and can make bundle persistence fail.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45633&comment_hash=b58e7cd939b4f26c026b91ab0a29d13fcbf4d4b5be5cbbb68dbeb842bba0be27&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45633&comment_hash=b58e7cd939b4f26c026b91ab0a29d13fcbf4d4b5be5cbbb68dbeb842bba0be27&reaction=dislike'>๐</a>
##########
superset/mcp_service/dataset/schemas.py:
##########
@@ -475,6 +476,16 @@ def expression_must_aggregate(cls, value: str) -> str:
)
return value
+ @field_validator("d3format")
+ @classmethod
+ def d3format_must_be_valid(cls, value: str | None) -> str | None:
+ if not is_valid_d3_format(value):
+ raise ValueError(
+ "Invalid number format: must be a d3-format specifier or a "
+ "supported named format"
+ )
+ return value
Review Comment:
**Suggestion:** This creation schema checks grammar but has no length cap, so an over-128-character format reaches the `String(128)` column and can make virtual-dataset creation fail.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incomplete implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7e8b21713c37419ab9baf796a6459dae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7e8b21713c37419ab9baf796a6459dae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/dataset/schemas.py
**Line:** 479:487
**Comment:**
*Incomplete Implementation: This creation schema checks grammar but has no length cap, so an over-128-character format reaches the `String(128)` column and can make virtual-dataset creation fail.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45633&comment_hash=084e92bcb1c1b3b84ae1d7fe366dfc0597f28b1a70fbb78e4744798ff94ce18e&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45633&comment_hash=084e92bcb1c1b3b84ae1d7fe366dfc0597f28b1a70fbb78e4744798ff94ce18e&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(datasets): validate metric d3format [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45633:
URL: https://github.com/apache/superset/pull/45633#issuecomment-6344364602
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45633?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.28571%` with `10 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.45%. Comparing base ([`47300cf`](https://app.codecov.io/gh/apache/superset/commit/47300cf4c2f13aa3a4bef6c7f349f58397de0035?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8192be6`](https://app.codecov.io/gh/apache/superset/commit/8192be6be6cff70fbdac6a248b689bcd917ecfe5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/45633?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/mcp\_service/dataset/schemas.py](https://app.codecov.io/gh/apache/superset/pull/45633?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fdataset%2Fschemas.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvZGF0YXNldC9zY2hlbWFzLnB5) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45633?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/utils/number\_format.py](https://app.codecov.io/gh/apache/superset/pull/45633?src=pr&el=tree&filepath=superset%2Futils%2Fnumber_format.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvbnVtYmVyX2Zvcm1hdC5weQ==) | 55.55% | [2 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/superset/pull/45633?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (47300cf) and HEAD (8192be6). Click for more details.
>
> <details><summary>HEAD has 5 uploads less than BASE</summary>
>
>| Flag | BASE (47300cf) | HEAD (8192be6) |
>|------|------|------|
>|python|7|3|
>|postgres|2|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #45633 +/- ##
===========================================
- Coverage 84.10% 65.45% -18.66%
===========================================
Files 3056 3056
Lines 201358 201384 +26
Branches 47085 47090 +5
===========================================
- Hits 169356 131806 -37550
- Misses 28756 66620 +37864
+ Partials 3246 2958 -288
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/45633/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage ฮ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/45633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/45633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/45633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.84% <64.28%> (+<0.01%)` | :arrow_up: |
| [presto](https://app.codecov.io/gh/apache/superset/pull/45633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.61% <53.57%> (+<0.01%)` | :arrow_up: |
| [python](https://app.codecov.io/gh/apache/superset/pull/45633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.04% <64.28%> (-34.31%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/45633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.60% <64.28%> (+<0.01%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/45633/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45633?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org