You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/27 08:22:16 UTC
[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue
#4945: make key-generator as a spring bean on spring namespace.
codecov-io edited a comment on issue #4945: make key-generator as a spring bean on spring namespace.
URL: https://github.com/apache/incubator-shardingsphere/pull/4945#issuecomment-604251543
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=h1) Report
> Merging [#4945](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/61378239e8a8ec7356677b7aff287b772c45c68f&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `94.11%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4945 +/- ##
============================================
- Coverage 54.54% 54.33% -0.22%
- Complexity 440 445 +5
============================================
Files 1136 1144 +8
Lines 20448 20524 +76
Branches 3758 3762 +4
============================================
- Hits 11154 11152 -2
- Misses 8586 8667 +81
+ Partials 708 705 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/shardingsphere/core/rule/TableRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1RhYmxlUnVsZS5qYXZh) | `84.09% <50.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...api/config/sharding/KeyGeneratorConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYXBpL2NvbmZpZy9zaGFyZGluZy9LZXlHZW5lcmF0b3JDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
| [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `74.34% <100.00%> (-5.24%)` | `0.00 <0.00> (ø)` | |
| [.../swapper/KeyGeneratorConfigurationYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL3N3YXBwZXIvS2V5R2VuZXJhdG9yQ29uZmlndXJhdGlvbllhbWxTd2FwcGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../factorybean/KeyGeneratorAlgorithmFactoryBean.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvZmFjdG9yeWJlYW4vS2V5R2VuZXJhdG9yQWxnb3JpdGhtRmFjdG9yeUJlYW4uamF2YQ==) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...space/parser/KeyGeneratorBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL0tleUdlbmVyYXRvckJlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=) | `100.00% <100.00%> (+18.18%)` | `1.00 <0.00> (ø)` | |
| [...che/shardingsphere/core/rule/BindingTableRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL0JpbmRpbmdUYWJsZVJ1bGUuamF2YQ==) | `73.07% <0.00%> (-26.93%)` | `0.00% <0.00%> (ø%)` | |
| [...underlying/common/database/type/DatabaseTypes.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2RhdGFiYXNlL3R5cGUvRGF0YWJhc2VUeXBlcy5qYXZh) | `83.33% <0.00%> (-7.15%)` | `0.00% <0.00%> (ø%)` | |
| [.../shardingsphere/core/shard/BaseShardingEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWVudHJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jb3JlL3NoYXJkL0Jhc2VTaGFyZGluZ0VuZ2luZS5qYXZh) | `83.33% <0.00%> (-3.04%)` | `0.00% <0.00%> (ø%)` | |
| ... and [59 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=footer). Last update [6137823...fe90913](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services