You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/28 12:10:55 UTC
[GitHub] [shardingsphere] Liangda-w opened a new pull request #12083: Parse package, type and indextype segment
Liangda-w opened a new pull request #12083:
URL: https://github.com/apache/shardingsphere/pull/12083
Relates #10513
Changes proposed in this pull request:
- Parse package, type and indextype segment
- Add corresponding test cases
@wgy8283335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 merged pull request #12083: Parse package, type and indextype segment
Posted by GitBox <gi...@apache.org>.
wgy8283335 merged pull request #12083:
URL: https://github.com/apache/shardingsphere/pull/12083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #12083: Parse package, type and indextype segment
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #12083:
URL: https://github.com/apache/shardingsphere/pull/12083#issuecomment-907627928
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12083?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#12083](https://codecov.io/gh/apache/shardingsphere/pull/12083?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5a6ddc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e62ecc7100d8951104f18af89e312708e31fc83e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e62ecc7) will **decrease** coverage by `0.17%`.
> The diff coverage is `26.66%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/12083?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #12083 +/- ##
============================================
- Coverage 63.24% 63.06% -0.18%
- Complexity 1230 1233 +3
============================================
Files 2308 2317 +9
Lines 35084 35204 +120
Branches 6101 6120 +19
============================================
+ Hits 22189 22202 +13
- Misses 11104 11209 +105
- Partials 1791 1793 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12083?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sql/common/segment/ddl/index/IndextypeSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZGRsL2luZGV4L0luZGV4dHlwZVNlZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ql/common/segment/ddl/packages/PackageSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZGRsL3BhY2thZ2VzL1BhY2thZ2VTZWdtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...arser/sql/common/segment/ddl/type/TypeSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZGRsL3R5cGUvVHlwZVNlZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...oracle/ddl/OracleAssociateStatisticsStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVBc3NvY2lhdGVTdGF0aXN0aWNzU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/statement/oracle/ddl/OracleCommentStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVDb21tZW50U3RhdGVtZW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...cle/ddl/OracleDisassociateStatisticsStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVEaXNhc3NvY2lhdGVTdGF0aXN0aWNzU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rized/asserts/segment/function/FunctionAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Z1bmN0aW9uL0Z1bmN0aW9uQXNzZXJ0LmphdmE=) | `0.00% <ø> (ø)` | |
| [...terized/asserts/segment/index/IndextypeAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2luZGV4L0luZGV4dHlwZUFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...erized/asserts/segment/packages/PackageAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L3BhY2thZ2VzL1BhY2thZ2VBc3NlcnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...parameterized/asserts/segment/type/TypeAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L3R5cGUvVHlwZUFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [25 more](https://codecov.io/gh/apache/shardingsphere/pull/12083/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12083?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12083?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e62ecc7...f5a6ddc](https://codecov.io/gh/apache/shardingsphere/pull/12083?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #12083: Parse package, type and indextype segment
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #12083:
URL: https://github.com/apache/shardingsphere/pull/12083#issuecomment-910148377
@wgy8283335 Hi This PR needs your review, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on pull request #12083: Parse package, type and indextype segment
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #12083:
URL: https://github.com/apache/shardingsphere/pull/12083#issuecomment-910955730
> @wgy8283335 Hi This PR needs your review, thanks.
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org