[GitHub] [ozone] smengcl commented on a diff in pull request #3753: HDDS-7222. Recon Inactive pipelines not shown.

[GitBox <gi...@apache.org>]

smengcl commented on code in PR #3753:
URL: https://github.com/apache/ozone/pull/3753#discussion_r971370378


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/pipelines/pipelines.tsx:
##########
@@ -247,7 +247,7 @@ export class Pipelines extends React.Component<Record<string, object>, IPipeline
                 }, [])}
                 loading={activeLoading} pagination={paginationConfig} rowKey='pipelineId'/>
             </TabPane>
-            <TabPane key='2' tab='Inactive'/>
+

Review Comment:
   hmm. Wouldn't a proper solution be **adding** inactive pipeline instead? Have we checked how much effort this would be to by modifying the [existing](https://github.com/apache/ozone/blob/ab608c5d4649b2b320e732b042998bf6ece77cc9/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/PipelineEndpoint.java#L72) endpoint (and possibly some OM code as well)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org