You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by mmiklavc <gi...@git.apache.org> on 2018/04/17 21:45:16 UTC
[GitHub] metron pull request #996: METRON-1528: Fix missing file in metron.spec
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/996
METRON-1528: Fix missing file in metron.spec
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1528
I missed the spec file addition for cluster_info.py in https://github.com/apache/metron/pull/988 - I must have run full dev up *before* adding the file and testing it in full dev, otherwise the rpm process would have failed.
## Pull Request Checklist
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
Doing this now
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
n/a
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron cluster-info-spec
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/996.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #996
----
commit b88ed71584a8105af441ade5d55c411cd05acccc
Author: Michael Miklavcic <mi...@...>
Date: 2018-04-17T21:36:11Z
Fix missing file in metron.spec
----
---
[GitHub] metron issue #996: METRON-1528: Fix missing file in metron.spec
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/996
Can you update the changelog?
---
[GitHub] metron pull request #996: METRON-1528: Fix missing file in metron.spec
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/996
---
[GitHub] metron issue #996: METRON-1528: Fix missing file in metron.spec
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/996
@justinleet Do we still want/need to do this? The last log change was Tue Sep 25 2017 by @merrimanr in METRON-1207. However, there have been 6 changes to the spec since then that have not made it to the change log. I believe there was a reason we started doing this (in duplication of source control), but I don't recall specifically. Do remember why that was?
---
[GitHub] metron issue #996: METRON-1528: Fix missing file in metron.spec
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/996
I believe, and my memory is pretty fuzzy, is that it's best practice to maintain that changelog because it's useful for auditing and tracking purposes given that it's available on the rpm itself.
There's probably a couple questions here
1. Are we going to maintain it going forward? If not, we should just dump it entirely.
2. If we choose to do so, do we want/need to update the changelog for the missing commits (and probably to use the dev list as authors, rather than individuals)?
Might be worth opening a discuss on it. I could be persuaded either way in terms of whether we update it for this PR or not, but I have a slight preference on adding it until there's agreement we aren't doing it.
---
[GitHub] metron issue #996: METRON-1528: Fix missing file in metron.spec
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/996
I'm +1 on this, to get the build working, with the understanding that there's follow up on resolving our best practices around the spec files.
---
[GitHub] metron issue #996: METRON-1528: Fix missing file in metron.spec
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/996
+1 by inspection. I would suggest we get this fix in ASAP so we can build. We can resolve the change log issue later.
---