You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/24 17:37:45 UTC
[GitHub] [geode] bschuchardt opened a new pull request #6184: GEODE-8963: update client/server on-wire version for 1.14.0
bschuchardt opened a new pull request #6184:
URL: https://github.com/apache/geode/pull/6184
Changes have been made to the unreleased support/1.14 branch to mark
that version as using 1.13.1 for client/server communications. This PR
updates develop to be consistent with the support branch.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] bschuchardt closed pull request #6184: GEODE-8963: update client/server on-wire version for 1.14.0
Posted by GitBox <gi...@apache.org>.
bschuchardt closed pull request #6184:
URL: https://github.com/apache/geode/pull/6184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] Bill commented on a change in pull request #6184: GEODE-8963: update client/server on-wire version for 1.14.0
Posted by GitBox <gi...@apache.org>.
Bill commented on a change in pull request #6184:
URL: https://github.com/apache/geode/pull/6184#discussion_r602531908
##########
File path: geode-serialization/src/main/java/org/apache/geode/internal/serialization/KnownVersion.java
##########
@@ -249,7 +249,7 @@
@Immutable
public static final KnownVersion GEODE_1_14_0 =
new KnownVersion("GEODE", "1.14.0", (byte) 1, (byte) 14, (byte) 0, (byte) 0,
- GEODE_1_14_0_ORDINAL, true);
+ GEODE_1_14_0_ORDINAL);
Review comment:
On the `support/1.14` branch the `GEODE_1_14_0` `KnownVersion` is constructed with `modifiesClientServerProtocol` set to `true`. Why does this PR change it back to `false`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org