[GitHub] [apisix] tzssangglass commented on a change in pull request #4980: fix(stream_route): replace ip match tools by using ipmatcher

[GitBox <gi...@apache.org>]

tzssangglass commented on a change in pull request #4980:
URL: https://github.com/apache/apisix/pull/4980#discussion_r702740839



##########
File path: t/stream-node/sanity.t
##########
@@ -281,3 +281,41 @@ GET /t
 hello world
 --- no_error_log
 [error]
+
+
+
+=== TEST 11: set stream route (id: 1) which uses upstream_id
+--- config
+    location /t {
+        content_by_lua_block {
+            local t = require("lib.test_admin").test
+            local code, body = t('/apisix/admin/stream_routes/1',
+                ngx.HTTP_PUT,
+                [[{
+                    "remote_addr": "127.0.0.1/26",
+                    "upstream_id": "1"
+                }]]
+            )
+            if code >= 300 then
+                ngx.status = code
+            end
+            ngx.say(body)
+        }
+    }
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 12: hit route
+--- stream_enable
+--- stream_request eval
+mmm
+--- stream_response
+hello world
+--- no_error_log
+[error]

Review comment:
       Add blank line at the end




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org