[GitHub] [james-project] chibenwa commented on a change in pull request #831: JAMES-3687 Demonstrate issues with deletes of delayed mails

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #831:
URL: https://github.com/apache/james-project/pull/831#discussion_r782254109



##########
File path: server/queue/queue-pulsar/src/test/java/org/apache/james/queue/pulsar/PulsarMailQueueTest.java
##########
@@ -238,4 +238,18 @@ private void assertThatStoreIsEmpty() {
     @Override
     public void flushShouldPreserveBrowseOrder() {
     }
+
+    @Test
+    @Override
+    @Disabled("JAMES-3687 Delayed deletes are buggy")
+    public void delayedEmailsShouldBeDeleted() {
+
+    }
+
+    @Test
+    @Override
+    @Disabled("JAMES-3687 Delayed deletes are buggy")
+    public void delayedEmailsShouldBeDeletedWhenMixedWithOtherEmails() {
+
+    }

Review comment:
       > you will need to @disable them in the PulsarMailqueueTest, we will enable them again when we merge (adding the 
   > @disabled will ensure we get a conflict when rebasing :)
   
   Isn't this done here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org