[GitHub] KellenSunderland commented on a change in pull request #11947: [MXNET-769] Usability improvements to windows builds

[GitBox <gi...@apache.org>]

KellenSunderland commented on a change in pull request #11947: [MXNET-769] Usability improvements to windows builds
URL: https://github.com/apache/incubator-mxnet/pull/11947#discussion_r207371029
 
 

 ##########
 File path: ci/build.py
 ##########
 @@ -138,24 +139,9 @@ def _get_local_image_id(docker_binary, docker_tag):
     return image_id
 
 
-def get_mxnet_root() -> str:
-    curpath = os.path.abspath(os.path.dirname(__file__))
-
-    def is_mxnet_root(path: str) -> bool:
-        return os.path.exists(os.path.join(path, ".mxnet_root"))
-
-    while not is_mxnet_root(curpath):
-        parent = os.path.abspath(os.path.join(curpath, os.pardir))
-        if parent == curpath:
-            raise RuntimeError("Got to the root and couldn't find a parent folder with .mxnet_root")
-        curpath = parent
-    return curpath
-
-
 def buildir() -> str:
     return os.path.join(get_mxnet_root(), "build")
 
-
 
 Review comment:
   Should be two spaces between defs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services