[jira] [Commented] (HBASE-12984) SSL cannot be used by the InfoPort after removing deprecated code in HBASE-10336

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310617#comment-14310617 ] 

Hadoop QA commented on HBASE-12984:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12697236/HBASE-12984-v1.txt
  against master branch at commit ac175b1bd9ec3878f50458382563810142df032d.
  ATTACHMENT ID: 12697236

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 5 new or modified tests.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail.

    Compilation errors resume:
    [ERROR] COMPILATION ERROR : 
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/http/InfoServer.java:[61,62] [StaticAccessedFromInstance] A static variable or method should not be accessed from an instance
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/http/InfoServer.java:[68,19] [StaticAccessedFromInstance] A static variable or method should not be accessed from an instance
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure:
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/http/InfoServer.java:[61,62] [StaticAccessedFromInstance] A static variable or method should not be accessed from an instance
[ERROR] (see http://code.google.com/p/error-prone/wiki/StaticAccessedFromInstance)
[ERROR] Did you mean 'builder.setName(name).addEndpoint(URI.create(HttpConfig.getSchemePrefix() +'?
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/http/InfoServer.java:[68,19] [StaticAccessedFromInstance] A static variable or method should not be accessed from an instance
[ERROR] (see http://code.google.com/p/error-prone/wiki/StaticAccessedFromInstance)
[ERROR] Did you mean 'if (HttpConfig.isSecure()) {'?
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hbase-server
    

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12731//console

This message is automatically generated.

> SSL cannot be used by the InfoPort after removing deprecated code in HBASE-10336
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-12984
>                 URL: https://issues.apache.org/jira/browse/HBASE-12984
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0, 1.1.0
>            Reporter: Esteban Gutierrez
>            Assignee: Esteban Gutierrez
>            Priority: Blocker
>         Attachments: HBASE-12984-v1.txt
>
>
> Setting {{hbase.ssl.enabled}} to {{true}} doesn't enable SSL on the InfoServer. Found that the problem is down the InfoServer and HttpConfig in how we setup the protocol in the HttpServer:
> {code}
> for (URI ep : endpoints) {
>         Connector listener = null;
>         String scheme = ep.getScheme();
>  if ("http".equals(scheme)) {
>           listener = HttpServer.createDefaultChannelConnector();
>         } else if ("https".equals(scheme)) {
>           SslSocketConnector c = new SslSocketConnectorSecure();
>           c.setNeedClientAuth(needsClientAuth);
>           c.setKeyPassword(keyPassword);
> {code}
> It depends what end points have been added by the InfoServer:
> {code}
> builder
>       .setName(name)
>       .addEndpoint(URI.create("http://" + bindAddress + ":" + port))
>       .setAppDir(HBASE_APP_DIR).setFindPort(findPort).setConf(c);
> {code}
> Basically we always use http and we don't look via HttConfig if {{hbase.ssl.enabled}} was set to true and we assign the right schema based on the configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)