[GitHub] [maven-surefire] Tibor17 commented on issue #269: [SUREFIRE-1748] Fix reporting of empty stack trace messages

[GitBox <gi...@apache.org>]

Tibor17 commented on issue #269: [SUREFIRE-1748] Fix reporting of empty stack trace messages
URL: https://github.com/apache/maven-surefire/pull/269#issuecomment-583112179
 
 
   @ajohnstonTE 
   Yes right! We can of course disscuss the transport layer and application layer of the protocol. You can see that the JSON is serialized and sent in a stream and therefore the transport layer should specify the number of bytes to transfer, similar to `Content-Length`. Additionally, the frame in the transport layer should start with the magic number in order to avoid fake streams.
   We don't have to use Base64 in this case with JSON.
   The current implementation uses Base64 which copes with non-ASCII encodings, and it avoids collisions with `:`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services