You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "arijitroy003 (via GitHub)" <gi...@apache.org> on 2026/07/29 12:14:16 UTC
[PR] Add .editorconfig for consistent coding style [spark]
arijitroy003 opened a new pull request, #57627:
URL: https://github.com/apache/spark/pull/57627
## Summary
Add an `.editorconfig` file to help maintain consistent coding style across editors, matching existing linter and style configurations.
## Changes
- Add `.editorconfig` with settings matching Spark's conventions: 2-space indent for Scala/Java/YAML, 4-space for Python, tab for Makefile
## Testing
N/A — editor configuration file only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][INFRA] Add .editorconfig for consistent coding style [spark]
Posted by "arijitroy003 (via GitHub)" <gi...@apache.org>.
arijitroy003 commented on PR #57627:
URL: https://github.com/apache/spark/pull/57627#issuecomment-5408948757
Thanks for the pointer to the contribution guidelines @dongjoon-hyun — I've reviewed both the contributing page and AGENTS.md. I've also added `max_line_length = 100` per @uros-b's review so editors can warn consistently with Spark's scalastyle/checkstyle/flake8 linters. Happy to create a JIRA ticket if needed for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Add .editorconfig for consistent coding style [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on code in PR #57627:
URL: https://github.com/apache/spark/pull/57627#discussion_r3674204398
##########
.editorconfig:
##########
@@ -0,0 +1,27 @@
+root = true
+
+[*]
Review Comment:
Should we also add `maxLineLength = 100`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org