You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by tonic889 <gi...@git.apache.org> on 2017/03/16 01:57:30 UTC
[GitHub] incubator-fineract pull request #315: fix for FINERACT-243 : Constitution ty...
GitHub user tonic889 opened a pull request:
https://github.com/apache/incubator-fineract/pull/315
fix for FINERACT-243 : Constitution type is not required field
modified: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientDataValidator.java
modified: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientNonPerson.java
new file: fineract-provider/src/main/resources/sql/migrations/core_db/V326__nonpersonclient_constitution_optional.sql
fix for FINERACT-243 : Constitution type is not required field
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tonic889/incubator-fineract develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #315
----
commit cb87df0a56e905ff6d7bf8a5f42b6bc57f908b3e
Author: tonic889 <to...@github.com>
Date: 2017-03-16T01:54:51Z
Changes to be committed:
modified: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientDataValidator.java
modified: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientNonPerson.java
new file: fineract-provider/src/main/resources/sql/migrations/core_db/V326__nonpersonclient_constitution_optional.sql
fix for FINERACT-243 : Constitution type is not required field
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #315: fix for FINERACT-243 : Constitution type is n...
Posted by tonic889 <gi...@git.apache.org>.
Github user tonic889 commented on the issue:
https://github.com/apache/incubator-fineract/pull/315
So what is the right way to avoid this duplication of effort again in the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #315: fix for FINERACT-243 : Constitution type is n...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/315
@tonic889 I have already done the changes and sent a PR on the same. Please look at https://github.com/apache/incubator-fineract/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---