You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "warrenzhu25 (via GitHub)" <gi...@apache.org> on 2023/05/07 05:15:57 UTC

[GitHub] [spark] warrenzhu25 commented on a diff in pull request #41076: [SPARK-43396][CORE] Add config to control max ratio of decommissioning executors

warrenzhu25 commented on code in PR #41076:
URL: https://github.com/apache/spark/pull/41076#discussion_r1186784134


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -2516,4 +2516,14 @@ package object config {
       .version("3.5.0")
       .booleanConf
       .createWithDefault(false)
+
+  private[spark] val DECOMMISSION_MAX_RATIO =
+    ConfigBuilder("spark.decommission.maxRatio")
+      .doc("Max ratio of decommissioning executor of running executors. Decommission too many " +
+        s"executors at the same time with shuffle or rdd migration enabled " +

Review Comment:
   Updated to only use this when data migration (shuffle and RDD) is not enabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org