You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2024/11/26 08:01:19 UTC
[PR] IGNITE-23774 Use shared threadpools in RocksDbFlusher for SharedRocksDbInstance [ignite-3]
tkalkirill opened a new pull request, #4791:
URL: https://github.com/apache/ignite-3/pull/4791
https://issues.apache.org/jira/browse/IGNITE-23774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23774 Use shared threadpools in RocksDbFlusher for SharedRocksDbInstance [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #4791:
URL: https://github.com/apache/ignite-3/pull/4791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23774 Use shared threadpools in RocksDbFlusher for SharedRocksDbInstance [ignite-3]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #4791:
URL: https://github.com/apache/ignite-3/pull/4791#discussion_r1858537572
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java:
##########
@@ -431,7 +431,7 @@ private void stopComponents() throws Exception {
);
}
- private static DataStorageManager createDataStorageManager(
+ private DataStorageManager createDataStorageManager(
ConfigurationRegistry mockedRegistry,
Path storagePath,
StorageConfiguration config,
Review Comment:
Looks like we can get rid of this parameters all together if are making this method non-static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org