[GitHub] [inlong] vernedeng commented on a diff in pull request #8089: [INLONG-8088][Manager] Support configure heartbeat timeout interval

["vernedeng (via GitHub)" <gi...@apache.org>]

vernedeng commented on code in PR #8089:
URL: https://github.com/apache/inlong/pull/8089#discussion_r1206158061


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/heartbeat/HeartbeatManager.java:
##########
@@ -106,7 +110,7 @@ public void init() {
         // When the manager restarts, set the heartbeat timeout state of all nodes
         // and wait for the heartbeat report of the corresponding node
         clusterNodeMapper.updateStatus(null, NodeStatus.HEARTBEAT_TIMEOUT.getStatus(), NodeStatus.NORMAL.getStatus());
-        long expireTime = heartbeatInterval() * 2L;
+        long expireTime = heartbeatInterval() * heartbeatInterval;

Review Comment:
   heartbeatInterval  -> heartbeatIntervalFactor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org