You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/17 09:20:31 UTC
[GitHub] [superset] dpgaspar commented on a change in pull request #19233: [WIP](docs):SECRET_KEY Rotation Documentation
dpgaspar commented on a change in pull request #19233:
URL: https://github.com/apache/superset/pull/19233#discussion_r828900526
##########
File path: docs/docs/installation/configuring-superset.mdx
##########
@@ -20,7 +20,10 @@ ROW_LIMIT = 5000
SUPERSET_WEBSERVER_PORT = 8088
# Flask App Builder configuration
-# Your App secret key
+# Your App secret key, this will be used for encrypting the data.
Review comment:
What do you think about:
`Your App secret key will be used for securely signing the session cookie and encrypting sensitive information on the database`
##########
File path: docs/docs/installation/configuring-superset.mdx
##########
@@ -20,7 +20,10 @@ ROW_LIMIT = 5000
SUPERSET_WEBSERVER_PORT = 8088
# Flask App Builder configuration
-# Your App secret key
+# Your App secret key, this will be used for encrypting the data.
+# Make sure you are changing this key for your deployment with a strong key.
+# You can generate a strong key using `openssl rand -base64 42`
+
SECRET_KEY = '\2\1thisismyscretkey\1\2\e\y\y\h'
Review comment:
let's remove this default on the docs
##########
File path: docs/docs/installation/running-on-kubernetes.mdx
##########
@@ -92,6 +92,34 @@ postgresql:
postgresqlPassword: superset
```
+Make sure you are giving your own SECRET_KEY for the encryption instead of default SECRET_KEY.
Review comment:
Consider replacing by:
"""
Make sure, you set a unique strong complex alphanumeric string for your `SECRET_KEY` and use a tool to help you generate a sufficiently random sequence
"""
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org