You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/06/28 19:00:21 UTC
[PR] refactor(frontend): remove unused FormlyRepeatDndComponent imports [texera]
Yicong-Huang opened a new pull request, #5975:
URL: https://github.com/apache/texera/pull/5975
### What changes were proposed in this PR?
`FormlyRepeatDndComponent` is a Formly custom field type, registered as `repeat-section-dnd` in `formly-config.ts` and instantiated dynamically by Formly at runtime. Its selector `texera-formly-repeat-section-dnd` never appears in any template, so listing it in a standalone component's `imports` array is redundant — and the Angular compiler emits one warning per component:
```
NG8113: FormlyRepeatDndComponent is not used within the template of <Component>
```
This PR removes the redundant import (the `import` statement and the `imports`-array entry) from the 10 standalone components that listed it, plus the matching NgModule import in `app.module.ts`.
The class is still imported and registered via `formly-config.ts`, which is the bundling anchor, so Formly continues to render `repeat-section-dnd` fields at runtime — no behavior change.
I also audited the other Formly dynamically-instantiated types/wrappers (`CodeareaCustomTemplateComponent`, `UiUdfParametersComponent`, `PresetWrapperComponent`, `CollabWrapperComponent`, etc.); `FormlyRepeatDndComponent` was the only one with stray standalone imports. `PresetWrapperComponent` is imported in `operator-property-edit-frame` but legitimately used via its static `setupFieldConfig` (not in the `imports` array), so it is left untouched.
### Any related issues, documentation, discussions?
Closes #5974
### How was this PR tested?
Static change only — removal of confirmed-unused imports. Verified the selector `texera-formly-repeat-section-dnd` is not referenced in any template and the symbol had no other usage in the affected files. Covered by existing build/CI.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove unused FormlyRepeatDndComponent imports [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5975:
URL: https://github.com/apache/texera/pull/5975#issuecomment-4827085129
<!-- texera:template-compliance -->
👋 Thanks for opening this pull request, @Yicong-Huang!
It looks like the pull request description doesn't quite follow our template yet:
- The **Was this PR authored or co-authored using generative AI tooling?** section is missing; please keep the template's headings.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove unused FormlyRepeatDndComponent imports [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5975:
URL: https://github.com/apache/texera/pull/5975#issuecomment-4827085497
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Ma77Ball`, `@kunwp1`
You can notify them by mentioning `@Ma77Ball`, `@kunwp1` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove unused FormlyRepeatDndComponent imports [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5975:
URL: https://github.com/apache/texera/pull/5975#issuecomment-4827100915
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5975?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.24%. Comparing base ([`1aae005`](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a33eda4`](https://app.codecov.io/gh/apache/texera/commit/a33eda4a5a2538a2066f37266aae6b4f8faa7292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5975 +/- ##
=========================================
Coverage 56.23% 56.24%
Complexity 2988 2988
=========================================
Files 1120 1120
Lines 43175 43165 -10
Branches 4658 4658
=========================================
- Hits 24281 24276 -5
+ Misses 17472 17464 -8
- Partials 1422 1425 +3
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [1aae005](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | Carriedforward from [1aae005](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.77% <ø> (ø)` | | Carriedforward from [1aae005](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [1aae005](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.56% <ø> (ø)` | | Carriedforward from [1aae005](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.02% <ø> (ø)` | | Carriedforward from [1aae005](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.30% <ø> (-0.01%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [1aae005](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.20% <ø> (ø)` | | Carriedforward from [1aae005](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.76% <ø> (ø)` | | Carriedforward from [1aae005](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [1aae005](https://app.codecov.io/gh/apache/texera/commit/1aae0059166a4557a0ccc82c2128d48fa7192f36?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5975?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove unused FormlyRepeatDndComponent imports [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 merged PR #5975:
URL: https://github.com/apache/texera/pull/5975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org