You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/10/22 13:21:56 UTC

[GitHub] rabbah commented on a change in pull request #2877: Better error controller message for authorization failure

rabbah commented on a change in pull request #2877: Better error controller message for authorization failure
URL: https://github.com/apache/incubator-openwhisk/pull/2877#discussion_r146131430
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/controller/test/EntitlementProviderTests.scala
 ##########
 @@ -534,25 +536,27 @@ class EntitlementProviderTests extends ControllerTestCommon with ScalaFutures {
     implicit val tid = transid()
     implicit val ep = entitlementProvider
 
+    val provider = WhiskPackage(someUser.namespace.toPath, MakeName.next(), None, publish = true)
+    val binding = WhiskPackage(guestUser.namespace.toPath, MakeName.next(), provider.bind)
+    val action = WhiskAction(binding.fullPath, MakeName.next(), jsDefault(""))
+    put(entityStore, provider)
+    put(entityStore, binding)
+    put(entityStore, action)
+
+    val resourceName = s"${binding.namespace}/${binding.name}"
 
 Review comment:
   I suggest using `binding.fullyQualifiedName(false).asString` instead here and elsewhere a name is constructed explicitly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services