[GitHub] [solr] janhoy commented on a diff in pull request #1500: remove-collections4

["janhoy (via GitHub)" <gi...@apache.org>]

janhoy commented on code in PR #1500:
URL: https://github.com/apache/solr/pull/1500#discussion_r1150999911


##########
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##########
@@ -762,7 +761,7 @@ private boolean returnStoredFields() {
     }
 
     private boolean returnDVFields() {
-      return CollectionUtils.isNotEmpty(dvFields);
+      return !(dvFields != null && dvFields.isEmpty());

Review Comment:
   A comment in line 738 says `dvFields` is always not null, not can simplify
   ```suggestion
         return !dvFields.isEmpty();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org