[GitHub] [hive] AngersZhuuuu commented on a change in pull request #3085: HIVE-26016: Remove duplicate table exists check in create_table_core api of HMSHandler

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #3085:
URL: https://github.com/apache/hive/pull/3085#discussion_r822382117



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -2333,11 +2333,6 @@ private void create_table_core(final RawStore ms, final CreateTableRequest req)
       isReplicated = isDbReplicationTarget(db);
 
       firePreEvent(new PreCreateTableEvent(tbl, db, this));
-      // get_table checks whether database exists, it should be moved here
-      if (is_table_exists(ms, tbl.getCatName(), tbl.getDbName(), tbl.getTableName())) {
-        throw new AlreadyExistsException("Table " + getCatalogQualifiedTableName(tbl)
-            + " already exists");
-      }

Review comment:
       We need to check  the check of `is_table_exists ` of line 2275. Not just remove code here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org