You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/03/30 00:44:12 UTC
Review Request 45455: Added test for recovering orphaned docker
containers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45455/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Timothy Chen.
Bugs: MESOS-3573
https://issues.apache.org/jira/browse/MESOS-3573
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp b9c26b92c44e8ca718a5eb333855199bdf2a8e81
Diff: https://reviews.apache.org/r/45455/diff/
Testing
-------
make check (gtest_repeat=100)
Thanks,
Anand Mazumdar
Re: Review Request 45455: Added test for recovering orphaned docker
containers.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45455/#review127126
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
src/tests/containerizer/docker_containerizer_tests.cpp (line 1381)
<https://reviews.apache.org/r/45455/#comment190261>
I think instead of just checking the previous inspect, can you make sure that the container is actually stopped by using exists?
- Timothy Chen
On March 29, 2016, 10:44 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45455/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 10:44 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Bugs: MESOS-3573
> https://issues.apache.org/jira/browse/MESOS-3573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp b9c26b92c44e8ca718a5eb333855199bdf2a8e81
>
> Diff: https://reviews.apache.org/r/45455/diff/
>
>
> Testing
> -------
>
> make check (gtest_repeat=100)
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 45455: Added test for recovering orphaned docker
containers.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45455/#review126037
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45453, 45454, 45455]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 29, 2016, 10:44 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45455/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 10:44 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Bugs: MESOS-3573
> https://issues.apache.org/jira/browse/MESOS-3573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp b9c26b92c44e8ca718a5eb333855199bdf2a8e81
>
> Diff: https://reviews.apache.org/r/45455/diff/
>
>
> Testing
> -------
>
> make check (gtest_repeat=100)
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 45455: Added test for recovering orphaned docker
containers.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45455/#review127248
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45453, 45454, 45455]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 5, 2016, 10:05 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45455/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 10:05 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Bugs: MESOS-3573
> https://issues.apache.org/jira/browse/MESOS-3573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp a2ac254423449a6e5185fe83177c45ce0d08420f
>
> Diff: https://reviews.apache.org/r/45455/diff/
>
>
> Testing
> -------
>
> make check (gtest_repeat=100)
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 45455: Added test for recovering orphaned docker
containers.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45455/
-----------------------------------------------------------
(Updated April 5, 2016, 10:05 p.m.)
Review request for mesos, Jie Yu and Timothy Chen.
Changes
-------
Review comment from Tim
Bugs: MESOS-3573
https://issues.apache.org/jira/browse/MESOS-3573
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp a2ac254423449a6e5185fe83177c45ce0d08420f
Diff: https://reviews.apache.org/r/45455/diff/
Testing
-------
make check (gtest_repeat=100)
Thanks,
Anand Mazumdar