You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Yishan Yang <yi...@amazon.com> on 2016/12/09 17:22:32 UTC
Re: Review Request 54557: Change the OozieShareLibCLI to perform a
final 'rename'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54557/
-----------------------------------------------------------
(Updated Dec. 9, 2016, 5:22 p.m.)
Review request for oozie and Andr�s Piros.
Repository: oozie-git
Description
-------
Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition where 'half' of the sharelib could exist during sharelib installation, if Oozie attempts to run a workflow at the same time as the sharelib installation. Oozie will only start if the sharelib exists, but this by itself is not enough since the sharelib could be in an unusable state.
Diffs
-----
tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java 9aa4cb6
Diff: https://reviews.apache.org/r/54557/diff/
Testing
-------
$ mvn test -Dtest=TestOozieSharelibCLI
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.497 sec
Results :
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Yishan Yang
Re: Review Request 54557: Change the OozieShareLibCLI to perform a
final 'rename'
Posted by Yishan Yang <yi...@amazon.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54557/
-----------------------------------------------------------
(Updated Dec. 13, 2016, 9:57 p.m.)
Review request for oozie and Andr�s Piros.
Changes
-------
Address comments
Repository: oozie-git
Description
-------
Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition where 'half' of the sharelib could exist during sharelib installation, if Oozie attempts to run a workflow at the same time as the sharelib installation. Oozie will only start if the sharelib exists, but this by itself is not enough since the sharelib could be in an unusable state.
Diffs (updated)
-----
tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java 9aa4cb6
Diff: https://reviews.apache.org/r/54557/diff/
Testing
-------
$ mvn test -Dtest=TestOozieSharelibCLI
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.497 sec
Results :
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Yishan Yang