You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/06 19:54:51 UTC

[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #459: Improve error log for frame size too big and maxMessageSize

merlimat commented on a change in pull request #459:
URL: https://github.com/apache/pulsar-client-go/pull/459#discussion_r571479063



##########
File path: pulsar/producer_partition.go
##########
@@ -348,7 +348,7 @@ func (p *partitionProducer) internalSend(request *sendRequest) {
 		p.log.WithError(errMessageTooLarge).
 			WithField("size", len(payload)).
 			WithField("properties", msg.Properties).
-			Error()
+			Errorf("MaxMessageSize %d", int(p.cnx.GetMaxMessageSize()))

Review comment:
       Should we keep this in a structured form instead? 
   ```suggestion
   
   			WithField("max-message-size", int(p.cnx.GetMaxMessageSize())).
   			Error()
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org