You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vy...@gmail.com> on 2015/03/24 02:47:19 UTC
Review Request 32425: Patch for SQOOP-2250
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32425/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2250
https://issues.apache.org/jira/browse/SQOOP-2250
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs
-----
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 039524a
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 3dbad01
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 4e1efc2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7af912d
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 662da9f
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 9ed7627
Diff: https://reviews.apache.org/r/32425/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 32425: Patch for SQOOP-2250
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32425/#review77864
-----------------------------------------------------------
Ship it!
Found one thing which makes more sense I think. Then LGTM.
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java
<https://reviews.apache.org/r/32425/#comment126188>
Looking this over one more time, could you change the WHEE clause and remove the AND in the join? Same with the LINK fetch statement?
- Abraham Elmahrek
On March 24, 2015, 1:47 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32425/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 1:47 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2250
> https://issues.apache.org/jira/browse/SQOOP-2250
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 039524a
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 3dbad01
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 4e1efc2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7af912d
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 662da9f
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 9ed7627
>
> Diff: https://reviews.apache.org/r/32425/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 32425: Patch for SQOOP-2250
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32425/#review77843
-----------------------------------------------------------
Ship it!
LGTM.
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java
<https://reviews.apache.org/r/32425/#comment126171>
Good catch
- Abraham Elmahrek
On March 24, 2015, 1:47 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32425/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 1:47 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2250
> https://issues.apache.org/jira/browse/SQOOP-2250
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 039524a
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 3dbad01
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 4e1efc2
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7af912d
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 662da9f
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 9ed7627
>
> Diff: https://reviews.apache.org/r/32425/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>