You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/11 05:24:50 UTC
[GitHub] TisonKun commented on a change in pull request #6678: [FLINK-10255]
Only react to onAddedJobGraph signal when being leader
TisonKun commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader
URL: https://github.com/apache/flink/pull/6678#discussion_r216548720
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/akka/ActorUtils.java
##########
@@ -85,5 +87,13 @@
return FutureUtils.completeAll(terminationFutures);
}
+ public static void stopActor(AkkaActorGateway akkaActorGateway) {
Review comment:
In this PR we introduce `stopActor` which is used at one place. After checking all our project, we have define many `stopActor` here and there. Most usages of them are from `TestingUtils` but there are also some from `MesosResourceManager` and `FlinkUntypedActorTest`. Sometimes use `PoisonPill` and sometimes use `Kill`.
Apart from this PR, since all stuff interact with Akka would depend on `flink-runtime`, let's unify stopActor Utils.
I think here, `ActorUtils` is the best place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services