[GitHub] incubator-carbondata pull request #148: [CARBONDATA-233] bad record logger s...

[sujith71955 <gi...@git.apache.org>]

Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/148#discussion_r82339778
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordslogger.java ---
    @@ -89,41 +95,55 @@ public static String hasBadRecord(String key) {
         return badRecordEntry.remove(key);
       }
     
    -  public void addBadRecordsToBilder(Object[] row, int size, String reason, String valueComparer) {
    +  public void addBadRecordsToBuilder(Object[] row, int size, String reason, String valueComparer,
    +      boolean badRecordsLogRedirect, boolean badRecordLoggerEnable) {
         StringBuilder logStrings = new StringBuilder();
    +    size = row.length;
    --- End diff --
    
    better to validate whether we need to log the bad record in the starting of method, and then continue the log string creation logic


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---