You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "philipgroet (via GitHub)" <gi...@apache.org> on 2023/05/02 14:42:19 UTC
[GitHub] [arrow] philipgroet opened a new pull request, #35386: MINOR: [archery] Fixed ArrowSources.__str__() not returning string
philipgroet opened a new pull request, #35386:
URL: https://github.com/apache/arrow/pull/35386
<!--
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
When no git repository is initialised in the `arrow/` directory, archery is supposed to raise an error. This error raises another error because the class ArrowSources does not have a proper `__repr__()` method. Below an example traceback:
```sh
Traceback (most recent call last):
File "/opt/homebrew/bin/archery", line 33, in <module>
sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())
File "/opt/homebrew/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
return self.main(*args, **kwargs)
File "/opt/homebrew/lib/python3.10/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/opt/homebrew/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/homebrew/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/homebrew/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/homebrew/lib/python3.10/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/opt/homebrew/lib/python3.10/site-packages/click/decorators.py", line 26, in new_func
return f(get_current_context(), *args, **kwargs)
File "/Users/philipgroet/projects/afstuderen/arrow/dev/archery/archery/cli.py", line 419, in benchmark_list
runner_base = CppBenchmarkRunner.from_rev_or_path(
File "/Users/philipgroet/projects/afstuderen/arrow/dev/archery/archery/benchmark/runner.py", line 222, in from_rev_or_path
src_rev, _ = src.at_revision(rev_or_path, clone_dir)
File "/Users/philipgroet/projects/afstuderen/arrow/dev/archery/archery/utils/source.py", line 151, in at_revision
raise ValueError("{} is not backed by git".format(self))
TypeError: __str__ returned non-string (type PosixPath)
```
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
The `self.path` attribute of ArrowSources is of type Path, we stringify it.
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Yes, now prints: `ValueError: /Users/philipgroet/projects/afstuderen/arrow is not backed by git`
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No, bugfix
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd merged pull request #35386: MINOR: [Archery] Fixed ArrowSources.__str__() not returning string
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #35386:
URL: https://github.com/apache/arrow/pull/35386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35386: MINOR: [Archery] Fixed ArrowSources.__str__() not returning string
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35386:
URL: https://github.com/apache/arrow/pull/35386#issuecomment-1533014139
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/536d3a2929894f629560e66253bb9418...8d0be02fd53c451985848e1288179e55/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35386: MINOR: [Archery] Fixed ArrowSources.__str__() not returning string
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35386:
URL: https://github.com/apache/arrow/pull/35386#issuecomment-1533011966
Benchmark runs are scheduled for baseline = a77aab07b02b7d0dd6bd9c9a11c4af067d26b674 and contender = f794b208ce70682f95bdce2339c4832c28045a4c. f794b208ce70682f95bdce2339c4832c28045a4c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/909e8b97a969464aa79dcbf5a1d2086d...c097e5fed88642f8815e24c9a494a12e/)
[Finished :arrow_down:1.19% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/536d3a2929894f629560e66253bb9418...8d0be02fd53c451985848e1288179e55/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/eaaad66f0fc445c18a309a446ebba5ed...ac9065653bce4562a3dcb873beddfb00/)
[Finished :arrow_down:0.33% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/029fef8d1f5e443cbe049e087c7964ff...2c4c9ee8fc524c6ebb74af3652c64d73/)
Buildkite builds:
[Finished] [`f794b208` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2811)
[Finished] [`f794b208` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2847)
[Finished] [`f794b208` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2811)
[Finished] [`f794b208` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2837)
[Finished] [`a77aab07` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2810)
[Finished] [`a77aab07` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2846)
[Finished] [`a77aab07` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2810)
[Finished] [`a77aab07` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2836)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #35386: MINOR: [archery] Fixed ArrowSources.__str__() not returning string
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #35386:
URL: https://github.com/apache/arrow/pull/35386#issuecomment-1531773316
Hey! Thanks for the contribution, especially for archery! I have approved the CI to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org