You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/07/09 00:12:27 UTC

[GitHub] [kylin] bigxiaochu opened a new pull request #1311: KYLIN-4626 add set kylin home shell

bigxiaochu opened a new pull request #1311:
URL: https://github.com/apache/kylin/pull/1311


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] coveralls commented on pull request #1311: KYLIN-4626 add set kylin home shell

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1311:
URL: https://github.com/apache/kylin/pull/1311#issuecomment-655848303


   ## Pull Request Test Coverage Report for [Build 6118](https://coveralls.io/builds/31954708)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **5** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.003%**) to **28.056%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/31954708/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46) | 5 | 66.67% |
   <!-- | **Total:** | **5** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/31954708/badge)](https://coveralls.io/builds/31954708) |
   | :-- | --: |
   | Change from base [Build 6117](https://coveralls.io/builds/31940525): |  -0.003% |
   | Covered Lines: | 26222 |
   | Relevant Lines: | 93464 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] bigxiaochu commented on pull request #1311: KYLIN-4626 add set kylin home shell

Posted by GitBox <gi...@apache.org>.
bigxiaochu commented on pull request #1311:
URL: https://github.com/apache/kylin/pull/1311#issuecomment-662516076


   @xiaowangyu how do you see


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] shaofengshi commented on a change in pull request #1311: KYLIN-4626 add set kylin home shell

Posted by GitBox <gi...@apache.org>.
shaofengshi commented on a change in pull request #1311:
URL: https://github.com/apache/kylin/pull/1311#discussion_r455608088



##########
File path: build/bin/set-kylin-home.sh
##########
@@ -0,0 +1 @@
+export KYLIN_HOME=$KYLIN_HOME

Review comment:
       hi xiao, what's the behavior of this line? If KYLIN_HOME already been set, will export it again bring any change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus merged pull request #1311: KYLIN-4626 add set kylin home shell

Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1311:
URL: https://github.com/apache/kylin/pull/1311


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] coveralls edited a comment on pull request #1311: KYLIN-4626 add set kylin home shell

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1311:
URL: https://github.com/apache/kylin/pull/1311#issuecomment-655848303


   ## Pull Request Test Coverage Report for [Build 6438](https://coveralls.io/builds/34072911)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **5** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.003%**) to **28.047%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/34072911/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46) | 5 | 66.67% |
   <!-- | **Total:** | **5** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/34072911/badge)](https://coveralls.io/builds/34072911) |
   | :-- | --: |
   | Change from base [Build 6416](https://coveralls.io/builds/33804340): |  -0.003% |
   | Covered Lines: | 26253 |
   | Relevant Lines: | 93602 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] coveralls edited a comment on pull request #1311: KYLIN-4626 add set kylin home shell

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1311:
URL: https://github.com/apache/kylin/pull/1311#issuecomment-655848303


   ## Pull Request Test Coverage Report for [Build 6249](https://coveralls.io/builds/32749993)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **7** unchanged lines in **2** files lost coverage.
   * Overall coverage remained the same at **28.027%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/32749993/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
   | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/32749993/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46) | 5 | 66.67% |
   <!-- | **Total:** | **7** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32749993/badge)](https://coveralls.io/builds/32749993) |
   | :-- | --: |
   | Change from base [Build 6246](https://coveralls.io/builds/32709065): |  0.0% |
   | Covered Lines: | 26237 |
   | Relevant Lines: | 93613 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org