You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ashnazg <gi...@git.apache.org> on 2015/12/03 18:32:09 UTC
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
GitHub user ashnazg opened a pull request:
https://github.com/apache/storm/pull/918
STORM-1365: Small improvements in Travis scripts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ashnazg/storm travisImprov
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/918.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #918
----
commit 365c340f655d7f20a533e5198df7e85bc737fbbf
Author: Chuck Burgess <cb...@progressrail.com>
Date: 2015-12-03T17:22:33Z
only show relevant tool versions for install step;
commit 4e585389281916dc9ac2bf00aa2fd5800b3de414
Author: Chuck Burgess <cb...@progressrail.com>
Date: 2015-12-03T17:22:59Z
simplify tool version echoes;
commit 0f922df8068ccf5209f28edfc046dbef4418e773
Author: Chuck Burgess <cb...@progressrail.com>
Date: 2015-12-03T17:23:55Z
RAT checks already happen in install step, thus here they are dead code;
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/918#issuecomment-161755488
Seems OK to me. I think the test failure was unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/918#issuecomment-162323754
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/918#issuecomment-161786050
+1 pending CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/918#discussion_r46612484
--- Diff: dev-tools/travis/travis-script.sh ---
@@ -31,7 +25,6 @@ cd ${STORM_SRC_ROOT_DIR}
# We should be concerned that Travis CI could be very slow because it uses VM
export STORM_TEST_TIMEOUT_MS=150000
-# We now lean on Travis CI's implicit behavior, ```mvn clean install -DskipTests``` before running script
--- End diff --
Sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/918#issuecomment-162327864
Thanks @ashnazg merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/918
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/918#issuecomment-161979869
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/918#discussion_r46596000
--- Diff: dev-tools/travis/travis-script.sh ---
@@ -31,7 +25,6 @@ cd ${STORM_SRC_ROOT_DIR}
# We should be concerned that Travis CI could be very slow because it uses VM
export STORM_TEST_TIMEOUT_MS=150000
-# We now lean on Travis CI's implicit behavior, ```mvn clean install -DskipTests``` before running script
--- End diff --
Was this comment incorrect or unhelpful?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/918#issuecomment-161785410
+1 looks good to me. @ashnazg you might want to rebase on master I think @d2r pulled out something that went in that was causing test failures, so you might get a clean run in travis now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1365: Small improvements in Travis scrip...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/918#discussion_r46611961
--- Diff: dev-tools/travis/travis-script.sh ---
@@ -31,7 +25,6 @@ cd ${STORM_SRC_ROOT_DIR}
# We should be concerned that Travis CI could be very slow because it uses VM
export STORM_TEST_TIMEOUT_MS=150000
-# We now lean on Travis CI's implicit behavior, ```mvn clean install -DskipTests``` before running script
--- End diff --
It is incorrect, because we don't do that any more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---