[GitHub] [trafficcontrol] zrhoffman commented on pull request #6278: TP: replace compass/ruby

[GitBox <gi...@apache.org>]

zrhoffman commented on pull request #6278:
URL: https://github.com/apache/trafficcontrol/pull/6278#issuecomment-944611938


   > ***Note***: CiaB (and associated CI) for TP _build_ will always fail (until merged) as it is using the dockerhub TP image, which was built using nodejs 10. `gulp-dart-sass` requires nodejs 12.
   
   > As noted in the PR description, actions are expected to fail due to bad published images on Dockerhub. The changes in this PR include a fix for that, but they can't be updated until it's merged.
   
   Our *build-rpms* action checks for whether the `GO_VERSION` file was changed in the last commit (or in the PR, if it's being run on a PR), and, if so, builds the builder image instead of pulling it:
   
   https://github.com/apache/trafficcontrol/blob/1f5610066c9191eeba29dcacb25182e6c676c82e/.github/actions/build-rpms/build-rpms.sh#L33-L35
   
   So the action would pass if you added the TP builder Dockerfile to the list of files to check for, in addition to GO_VERSION (see #6210, which adds the TR builder Dockerfile).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org