You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/16 09:59:27 UTC

[GitHub] [airflow] plaes commented on a change in pull request #10967: Remove redundant parentheses from Python files

plaes commented on a change in pull request #10967:
URL: https://github.com/apache/airflow/pull/10967#discussion_r489316323



##########
File path: airflow/migrations/versions/952da73b5eff_add_dag_code_table.py
##########
@@ -59,7 +59,7 @@ class SerializedDagModel(Base):
                     sa.Column('last_updated', sa.TIMESTAMP(timezone=True), nullable=False))
 
     conn = op.get_bind()
-    if conn.dialect.name not in ('sqlite'):
+    if conn.dialect.name not in 'sqlite':

Review comment:
       It seems that original code was actually wrong:
   ```
   'sql' in 'sqlite' => True
   'sql' in ('sqlite',) => False
   ```
   So, original code should actually be: `.. not in ('sqlite',)`:
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org