You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/09 10:02:10 UTC
[GitHub] [airflow] bhavaniravi opened a new pull request #20158: 20139 - organize aws step_function
bhavaniravi opened a new pull request #20158:
URL: https://github.com/apache/airflow/pull/20158
Part of #20139
Move step_function_* operators and sensors to `step_function.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #20158: 20139 - organize aws step_function
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #20158:
URL: https://github.com/apache/airflow/pull/20158#issuecomment-991862840
@bhavaniravi could you please address also the comments on test files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20158: 20139 - organize aws step_function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20158:
URL: https://github.com/apache/airflow/pull/20158#issuecomment-992281475
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bhavaniravi commented on pull request #20158: 20139 - organize aws step_function
Posted by GitBox <gi...@apache.org>.
bhavaniravi commented on pull request #20158:
URL: https://github.com/apache/airflow/pull/20158#issuecomment-992122586
> @bhavaniravi could you please address also the comments on test files?
Yes on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #20158: 20139 - organize aws step_function
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #20158:
URL: https://github.com/apache/airflow/pull/20158#discussion_r766575209
##########
File path: tests/deprecated_classes.py
##########
@@ -1518,6 +1518,16 @@
'airflow.providers.amazon.aws.operators.s3_file_transform.S3FileTransformOperator',
'airflow.operators.s3_file_transform_operator.S3FileTransformOperator',
),
+ (
+ 'airflow.providers.amazon.aws.operators.step_function.StepFunctionStartExecutionOperator',
+ 'airflow.providers.amazon.aws.operators.s3_file_transform_operator.'
+ 'StepFunctionStartExecutionOperator',
Review comment:
what is this extra entry?
##########
File path: tests/deprecated_classes.py
##########
@@ -1518,6 +1518,16 @@
'airflow.providers.amazon.aws.operators.s3_file_transform.S3FileTransformOperator',
'airflow.operators.s3_file_transform_operator.S3FileTransformOperator',
),
+ (
+ 'airflow.providers.amazon.aws.operators.step_function.StepFunctionStartExecutionOperator',
+ 'airflow.providers.amazon.aws.operators.s3_file_transform_operator.'
+ 'StepFunctionStartExecutionOperator',
+ ),
+ (
+ 'airflow.providers.amazon.aws.operators.step_function.StepFunctionGetExecutionOutputOperator',
+ 'airflow.providers.amazon.aws.operators.step_function_get_execution_output.'
+ 'StepFunctionGetExecutionOutputOperator',
Review comment:
same question
##########
File path: tests/deprecated_classes.py
##########
@@ -1518,6 +1518,16 @@
'airflow.providers.amazon.aws.operators.s3_file_transform.S3FileTransformOperator',
'airflow.operators.s3_file_transform_operator.S3FileTransformOperator',
),
+ (
+ 'airflow.providers.amazon.aws.operators.step_function.StepFunctionStartExecutionOperator',
+ 'airflow.providers.amazon.aws.operators.s3_file_transform_operator.'
Review comment:
this is a wrong file name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #20158: 20139 - organize aws step_function
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #20158:
URL: https://github.com/apache/airflow/pull/20158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bhavaniravi commented on a change in pull request #20158: 20139 - organize aws step_function
Posted by GitBox <gi...@apache.org>.
bhavaniravi commented on a change in pull request #20158:
URL: https://github.com/apache/airflow/pull/20158#discussion_r766584982
##########
File path: tests/deprecated_classes.py
##########
@@ -1518,6 +1518,16 @@
'airflow.providers.amazon.aws.operators.s3_file_transform.S3FileTransformOperator',
'airflow.operators.s3_file_transform_operator.S3FileTransformOperator',
),
+ (
+ 'airflow.providers.amazon.aws.operators.step_function.StepFunctionStartExecutionOperator',
+ 'airflow.providers.amazon.aws.operators.s3_file_transform_operator.'
+ 'StepFunctionStartExecutionOperator',
Review comment:
It's how long string have been handled in this file
https://github.com/apache/airflow/blob/main/tests/deprecated_classes.py#L474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org