You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "dimas-b (via GitHub)" <gi...@apache.org> on 2026/03/12 15:12:19 UTC
[PR] Remove unused PolarisAuthorizableOperation values [polaris]
dimas-b opened a new pull request, #3991:
URL: https://github.com/apache/polaris/pull/3991
* `REVOKE_PRINCIPAL_GRANT_FROM_PRINCIPAL_ROLE`
* `REVOKE_PRINCIPAL_ROLE_GRANT_FROM_PRINCIPAL_ROLE`
<!--
๐ Describe what changes you're proposing, especially breaking or user-facing changes.
๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
-->
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact security@apache.org)
- [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "nandorKollar (via GitHub)" <gi...@apache.org>.
nandorKollar commented on code in PR #3991:
URL: https://github.com/apache/polaris/pull/3991#discussion_r2935859221
##########
CHANGELOG.md:
##########
@@ -72,6 +72,7 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- Changed from Poetry to UV for Python package management.
- Exclude KMS policies when KMS is not being used for S3.
- Improved default KMS permission handling to better distinguish read-only and read-write access.
+- Removed unused `PolarisAuthorizableOperation` values: `REVOKE_PRINCIPAL_GRANT_FROM_PRINCIPAL_ROLE`, `REVOKE_PRINCIPAL_ROLE_GRANT_FROM_PRINCIPAL_ROLE`.
Review Comment:
Should we maybe add these to the list of breaking changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #3991:
URL: https://github.com/apache/polaris/pull/3991#issuecomment-4058610750
Can we update it in the change log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "nandorKollar (via GitHub)" <gi...@apache.org>.
nandorKollar commented on PR #3991:
URL: https://github.com/apache/polaris/pull/3991#issuecomment-4050129645
Just a quick question: why do we remove only these two operations? Among others, `ADD_PRINCIPAL_ROLE_GRANT_TO_PRINCIPAL_ROLE` and `ADD_PRINCIPAL_GRANT_TO_PRINCIPAL_ROLE` seems also unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #3991:
URL: https://github.com/apache/polaris/pull/3991#discussion_r2935898218
##########
CHANGELOG.md:
##########
@@ -72,6 +72,7 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- Changed from Poetry to UV for Python package management.
- Exclude KMS policies when KMS is not being used for S3.
- Improved default KMS permission handling to better distinguish read-only and read-write access.
+- Removed unused `PolarisAuthorizableOperation` values: `REVOKE_PRINCIPAL_GRANT_FROM_PRINCIPAL_ROLE`, `REVOKE_PRINCIPAL_ROLE_GRANT_FROM_PRINCIPAL_ROLE`.
Review Comment:
I think it's fine here. As it was not used anymore, not sure we can consider as a strict breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3991:
URL: https://github.com/apache/polaris/pull/3991#issuecomment-4050477703
> the key question here is not whether Polaris core still emits these operations, but whether PolarisAuthorizableOperation is part of the current public auth vocabulary [...]
Current [Polaris Evolution](https://polaris.apache.org/in-dev/unreleased/evolution/) guidelines do not consider java code (whether public or not) to be part of the API surface in the SemVer sense.
Additionally, since these values were not used in Polaris code, any softly-linked user-driven configuration that may reference them can probably be expected to remain operation (albeit pointless).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3991:
URL: https://github.com/apache/polaris/pull/3991#issuecomment-4058721110
Rebased. Added an entry to CHANGELOG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3991:
URL: https://github.com/apache/polaris/pull/3991#issuecomment-4057853617
Related `dev` discussion: https://lists.apache.org/thread/gocs3lbl4w6x3tpso0wjos6sr8ctffl8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3991:
URL: https://github.com/apache/polaris/pull/3991#issuecomment-4050451155
> Just a quick question: why do we remove only these two operations [...]
Just what I personally noticed :sweat_smile: Please feel free to open similar cleanup PR for removing other unused code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #3991:
URL: https://github.com/apache/polaris/pull/3991#issuecomment-4048118866
cc @collado-mike @dennishuo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3991:
URL: https://github.com/apache/polaris/pull/3991#discussion_r2940082591
##########
CHANGELOG.md:
##########
@@ -72,6 +72,7 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- Changed from Poetry to UV for Python package management.
- Exclude KMS policies when KMS is not being used for S3.
- Improved default KMS permission handling to better distinguish read-only and read-write access.
+- Removed unused `PolarisAuthorizableOperation` values: `REVOKE_PRINCIPAL_GRANT_FROM_PRINCIPAL_ROLE`, `REVOKE_PRINCIPAL_ROLE_GRANT_FROM_PRINCIPAL_ROLE`.
Review Comment:
I do not see any potential for breakage - commented about that in the main comment thread above and on `dev`: https://lists.apache.org/thread/gocs3lbl4w6x3tpso0wjos6sr8ctffl8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3991:
URL: https://github.com/apache/polaris/pull/3991#discussion_r2940082591
##########
CHANGELOG.md:
##########
@@ -72,6 +72,7 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- Changed from Poetry to UV for Python package management.
- Exclude KMS policies when KMS is not being used for S3.
- Improved default KMS permission handling to better distinguish read-only and read-write access.
+- Removed unused `PolarisAuthorizableOperation` values: `REVOKE_PRINCIPAL_GRANT_FROM_PRINCIPAL_ROLE`, `REVOKE_PRINCIPAL_ROLE_GRANT_FROM_PRINCIPAL_ROLE`.
Review Comment:
I do not see any potential for breakage - commented about that in the main comment thread above and on `dev: https://lists.apache.org/thread/gocs3lbl4w6x3tpso0wjos6sr8ctffl8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused PolarisAuthorizableOperation values [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3991:
URL: https://github.com/apache/polaris/pull/3991#issuecomment-4067335344
Consensus appears to exist based on GH comments and `dev` discussion: https://lists.apache.org/thread/gocs3lbl4w6x3tpso0wjos6sr8ctffl8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org