You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/08/19 17:29:28 UTC
[GitHub] [tvm] Lyken17 opened a new pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument
Lyken17 opened a new pull request #8799:
URL: https://github.com/apache/tvm/pull/8799
As mentioned in https://github.com/apache/tvm/issues/8182, `TranposedConv2d` is an important operator in GAN related applications and `groups` should also be supported for this operator. This PR was set to implement this missing feature.
However, there are parts I am still confusing
* Which names should be used for the topi function?
In topi.nn.conv2d, there are `data, kernel, strides, padding, out_dtype, output_padding` as well as `Input, Filter, strides, padding, out_dtype, output_padding`, which one should be used for newly added function?
* Should we add a new function, or extend existing ones?
In most DL frameoworks (e.g., PyTorch), `conv2d` is a unified function with support of various arguments such as padding, dilation, groups. But in `topi`, `conv2d` (w/o groups) and `group_conv2d` are two differnet function. While I understand this might be important to backward compability, I would recommend to merge these functions for simplicty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lyken17 commented on pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument
Posted by GitBox <gi...@apache.org>.
Lyken17 commented on pull request #8799:
URL: https://github.com/apache/tvm/pull/8799#issuecomment-904578685
@vinx13 What is relationship between `topi.nn` and `relay.nn`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #8799:
URL: https://github.com/apache/tvm/pull/8799#issuecomment-904816930
`relay.nn` is graph level operator, `topi.nn` is the platform-aware implementation of each operator. There is a lowering rule registered here https://github.com/apache/tvm/blob/596ff5cff576d8ded1251bb936eb7198551cc481/python/tvm/relay/op/strategy/generic.py#L249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lyken17 closed pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument
Posted by GitBox <gi...@apache.org>.
Lyken17 closed pull request #8799:
URL: https://github.com/apache/tvm/pull/8799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #8799:
URL: https://github.com/apache/tvm/pull/8799#issuecomment-909711370
@Lyken17 could you add a test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #8799:
URL: https://github.com/apache/tvm/pull/8799#issuecomment-904153346
Merging these functions sounds good to me. Note that we have unified operators in Relay level, it might be fine to lower to different topi operators if this is simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #8799: Add group_conv2d_transpose_nchw to support `groups` argument
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #8799:
URL: https://github.com/apache/tvm/pull/8799#issuecomment-909711370
@Lyken17 could you add a test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org