You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/11 01:11:39 UTC
[GitHub] [skywalking] cui-liqiang opened a new pull request #4346: some code
style
cui-liqiang opened a new pull request #4346: some code style
URL: https://github.com/apache/skywalking/pull/4346
Signed-off-by: liqiang.clq <li...@alibaba-inc.com>
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
None of above, just some code style changes mainly in three patterns:
1. Change "if(<expression>) return true; return false" to "return <expression>;".
2. Change "while(<expression>) return xxx" to "if(<expression>) return xxx".
3. Remove "public" method modifier in interface definition.
Please let me know if these patterns are intentional.
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cui-liqiang closed pull request #4346: some code style
Posted by GitBox <gi...@apache.org>.
cui-liqiang closed pull request #4346: some code style
URL: https://github.com/apache/skywalking/pull/4346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services