[GitHub] [lucene] uschindler commented on pull request #12253: GITHUB-12252: Add function queries for computing similarity scores between knn vectors

["uschindler (via GitHub)" <gi...@apache.org>]

uschindler commented on PR #12253:
URL: https://github.com/apache/lucene/pull/12253#issuecomment-1590565045

   Hi,
   looks much better now.
   
   Why does the `ConstKnn*VectorValueSource` take this strange `List<Number>` as constructor parameter? Mapping a list of Numbers to a vector is not the responsibility of Lucene. Lucene's code should just take a `byte[]` or `float[]` in its constrcutor.
   
   If this was added for Solr, please move this conversion to a primitive vector there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org