You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/27 19:31:44 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request, #2887: Add Ethernet driver for pic32
kasjer opened a new pull request, #2887:
URL: https://github.com/apache/mynewt-core/pull/2887
This adds Ethernet driver for PIC32.
Functionality is very similar to STM32 counterpart.
It supports LAN8710/LAN8720/LAN8740/LAN8742 transceivers both RMII and MII.
Second commits adds basic shell that can show some stats and registers.
Later PRs will add this driver to MCU and BSPs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2887: Add Ethernet driver for pic32
Posted by GitBox <gi...@apache.org>.
kasjer merged PR #2887:
URL: https://github.com/apache/mynewt-core/pull/2887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2887: Add Ethernet driver for pic32
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #2887:
URL: https://github.com/apache/mynewt-core/pull/2887#issuecomment-1262660518
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2887: Add Ethernet driver for pic32
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #2887:
URL: https://github.com/apache/mynewt-core/pull/2887#issuecomment-1259967025
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/lwip/pic32_eth/include/pic32_eth/pic32_eth_priv.h
<details>
```diff
@@ -35,18 +35,17 @@
uint32_t imem;
};
-struct pic32_eth_desc
-{
+struct pic32_eth_desc {
volatile union {
struct {
- uint32_t: 7;
- uint32_t EOWN: 1;
- uint32_t NPV: 1;
- uint32_t: 7;
- uint32_t BYTE_COUNT: 11;
- uint32_t: 3;
- uint32_t EOP: 1;
- uint32_t SOP: 1;
+ uint32_t : 7;
+ uint32_t EOWN : 1;
+ uint32_t NPV : 1;
+ uint32_t : 7;
+ uint32_t BYTE_COUNT : 11;
+ uint32_t : 3;
+ uint32_t EOP : 1;
+ uint32_t SOP : 1;
};
uint32_t w;
} hdr;
```
</details>
#### hw/drivers/lwip/pic32_eth/src/pic32_eth.c
<details>
```diff
@@ -481,7 +481,7 @@
ETHCON1CLR = _ETHCON1_ON_MASK;
ETHCON1CLR = _ETHCON1_RXEN_MASK | _ETHCON1_TXRTS_MASK;
/* 1.c */
- while (ETHSTATbits.BUSY) ;
+ while (ETHSTATbits.BUSY);
/* 1.d */
IFS4CLR = _IFS4_ETHIF_MASK;
/* 1.e */
@@ -490,7 +490,8 @@
ETHTXST = 0;
ETHRXST = 0;
- ETHRXFC = _ETHRXFC_CRCOKEN_MASK | _ETHRXFC_RUNTEN_MASK | _ETHRXFC_UCEN_MASK | _ETHRXFC_BCEN_MASK | _ETHRXFC_MCEN_MASK;
+ ETHRXFC = _ETHRXFC_CRCOKEN_MASK | _ETHRXFC_RUNTEN_MASK | _ETHRXFC_UCEN_MASK | _ETHRXFC_BCEN_MASK |
+ _ETHRXFC_MCEN_MASK;
/* 2. MAC initialization */
/* 2.a */
```
</details>
#### hw/drivers/lwip/pic32_eth/src/pic32_eth_shell.c
<details>
```diff
@@ -115,34 +115,34 @@
(void)argc;
(void)argv;
- streamer_printf(streamer, " ETHCON1 0x%08"PRIx32"\n", ETHCON1);
- streamer_printf(streamer, " ETHCON2 0x%08"PRIx32"\n", ETHCON2);
- streamer_printf(streamer, " ETHTXST 0x%08"PRIx32"\n", ETHTXST);
- streamer_printf(streamer, " ETHRXST 0x%08"PRIx32"\n", ETHRXST);
- streamer_printf(streamer, " ETHHT0 0x%08"PRIx32"\n", ETHHT0);
- streamer_printf(streamer, " ETHHT1 0x%08"PRIx32"\n", ETHHT1);
- streamer_printf(streamer, " ETHPMM0 0x%08"PRIx32"\n", ETHPMM0);
- streamer_printf(streamer, " ETHPMM1 0x%08"PRIx32"\n", ETHPMM1);
- streamer_printf(streamer, " ETHPMCS 0x%08"PRIx32"\n", ETHPMCS);
- streamer_printf(streamer, " ETHPMO 0x%08"PRIx32"\n", ETHPMO);
- streamer_printf(streamer, " ETHRXFC 0x%08"PRIx32"\n", ETHRXFC);
- streamer_printf(streamer, " ETHRXWM 0x%08"PRIx32"\n", ETHRXWM);
- streamer_printf(streamer, " ETHIEN 0x%08"PRIx32"\n", ETHIEN);
- streamer_printf(streamer, " ETHIRQ 0x%08"PRIx32"\n", ETHIRQ);
- streamer_printf(streamer, " ETHSTAT 0x%08"PRIx32"\n", ETHSTAT);
- streamer_printf(streamer, "THRXOVFLOW 0x%08"PRIx32"\n", ETHRXOVFLOW);
- streamer_printf(streamer, "ETHFRMTXOK 0x%08"PRIx32"\n", ETHFRMTXOK);
- streamer_printf(streamer, "ETHFRMRXOK 0x%08"PRIx32"\n", ETHFRMRXOK);
- streamer_printf(streamer, "ETHSCOLFRM 0x%08"PRIx32"\n", ETHSCOLFRM);
- streamer_printf(streamer, "ETHMCOLFRM 0x%08"PRIx32"\n", ETHMCOLFRM);
- streamer_printf(streamer, "ETHFRMRXOK 0x%08"PRIx32"\n", ETHFRMRXOK);
- streamer_printf(streamer, " ETHFCSERR 0x%08"PRIx32"\n", ETHFCSERR);
- streamer_printf(streamer, "ETHALGNERR 0x%08"PRIx32"\n", ETHALGNERR);
- streamer_printf(streamer, " EMAC1CFG1 0x%08"PRIx32"\n", EMAC1CFG1);
- streamer_printf(streamer, " EMAC1CFG2 0x%08"PRIx32"\n", EMAC1CFG2);
- streamer_printf(streamer, " EMAC1IPGT 0x%08"PRIx32"\n", EMAC1IPGT);
- streamer_printf(streamer, " EMAC1IPGR 0x%08"PRIx32"\n", EMAC1IPGR);
- streamer_printf(streamer, " EMAC1MADR 0x%08"PRIx32"\n", EMAC1MADR);
+ streamer_printf(streamer, " ETHCON1 0x%08" PRIx32 "\n", ETHCON1);
+ streamer_printf(streamer, " ETHCON2 0x%08" PRIx32 "\n", ETHCON2);
+ streamer_printf(streamer, " ETHTXST 0x%08" PRIx32 "\n", ETHTXST);
+ streamer_printf(streamer, " ETHRXST 0x%08" PRIx32 "\n", ETHRXST);
+ streamer_printf(streamer, " ETHHT0 0x%08" PRIx32 "\n", ETHHT0);
+ streamer_printf(streamer, " ETHHT1 0x%08" PRIx32 "\n", ETHHT1);
+ streamer_printf(streamer, " ETHPMM0 0x%08" PRIx32 "\n", ETHPMM0);
+ streamer_printf(streamer, " ETHPMM1 0x%08" PRIx32 "\n", ETHPMM1);
+ streamer_printf(streamer, " ETHPMCS 0x%08" PRIx32 "\n", ETHPMCS);
+ streamer_printf(streamer, " ETHPMO 0x%08" PRIx32 "\n", ETHPMO);
+ streamer_printf(streamer, " ETHRXFC 0x%08" PRIx32 "\n", ETHRXFC);
+ streamer_printf(streamer, " ETHRXWM 0x%08" PRIx32 "\n", ETHRXWM);
+ streamer_printf(streamer, " ETHIEN 0x%08" PRIx32 "\n", ETHIEN);
+ streamer_printf(streamer, " ETHIRQ 0x%08" PRIx32 "\n", ETHIRQ);
+ streamer_printf(streamer, " ETHSTAT 0x%08" PRIx32 "\n", ETHSTAT);
+ streamer_printf(streamer, "THRXOVFLOW 0x%08" PRIx32 "\n", ETHRXOVFLOW);
+ streamer_printf(streamer, "ETHFRMTXOK 0x%08" PRIx32 "\n", ETHFRMTXOK);
+ streamer_printf(streamer, "ETHFRMRXOK 0x%08" PRIx32 "\n", ETHFRMRXOK);
+ streamer_printf(streamer, "ETHSCOLFRM 0x%08" PRIx32 "\n", ETHSCOLFRM);
+ streamer_printf(streamer, "ETHMCOLFRM 0x%08" PRIx32 "\n", ETHMCOLFRM);
+ streamer_printf(streamer, "ETHFRMRXOK 0x%08" PRIx32 "\n", ETHFRMRXOK);
+ streamer_printf(streamer, " ETHFCSERR 0x%08" PRIx32 "\n", ETHFCSERR);
+ streamer_printf(streamer, "ETHALGNERR 0x%08" PRIx32 "\n", ETHALGNERR);
+ streamer_printf(streamer, " EMAC1CFG1 0x%08" PRIx32 "\n", EMAC1CFG1);
+ streamer_printf(streamer, " EMAC1CFG2 0x%08" PRIx32 "\n", EMAC1CFG2);
+ streamer_printf(streamer, " EMAC1IPGT 0x%08" PRIx32 "\n", EMAC1IPGT);
+ streamer_printf(streamer, " EMAC1IPGR 0x%08" PRIx32 "\n", EMAC1IPGR);
+ streamer_printf(streamer, " EMAC1MADR 0x%08" PRIx32 "\n", EMAC1MADR);
return 0;
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org