You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/02/28 21:55:35 UTC
Review Request 18642: Refactored cpu control writes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18642/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/linux/cgroups.hpp 2f4ab256a5cee6a416b353316f6bd4eeec4f95f7
src/linux/cgroups.cpp 4bf7f26ce96b96b91ebe653b31fa9c27a9ee0a21
src/slave/containerizer/isolators/cgroups/cpushare.cpp 160e8fe5eb06a2f65924734157b7b8d468d8be36
Diff: https://reviews.apache.org/r/18642/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 18642: Refactored cpu control writes.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18642/#review35857
-----------------------------------------------------------
Ship it!
src/linux/cgroups.cpp
<https://reviews.apache.org/r/18642/#comment66637>
kill newline
- Ben Mahler
On Feb. 28, 2014, 10:13 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18642/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2014, 10:13 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 2f4ab256a5cee6a416b353316f6bd4eeec4f95f7
> src/linux/cgroups.cpp 4bf7f26ce96b96b91ebe653b31fa9c27a9ee0a21
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 160e8fe5eb06a2f65924734157b7b8d468d8be36
> src/tests/cgroups_tests.cpp b9ec276e63df23e53508e12d529ffbcbe6e5c907
>
> Diff: https://reviews.apache.org/r/18642/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 18642: Refactored cpu control writes.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18642/
-----------------------------------------------------------
(Updated Feb. 28, 2014, 10:13 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
benm's and dominic's.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/linux/cgroups.hpp 2f4ab256a5cee6a416b353316f6bd4eeec4f95f7
src/linux/cgroups.cpp 4bf7f26ce96b96b91ebe653b31fa9c27a9ee0a21
src/slave/containerizer/isolators/cgroups/cpushare.cpp 160e8fe5eb06a2f65924734157b7b8d468d8be36
src/tests/cgroups_tests.cpp b9ec276e63df23e53508e12d529ffbcbe6e5c907
Diff: https://reviews.apache.org/r/18642/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 18642: Refactored cpu control writes.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18642/#review35844
-----------------------------------------------------------
Ship it!
src/linux/cgroups.hpp
<https://reviews.apache.org/r/18642/#comment66614>
remove const
src/linux/cgroups.cpp
<https://reviews.apache.org/r/18642/#comment66615>
remove const
src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/18642/#comment66616>
s/cpu/'cpu'/ ?
src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/18642/#comment66617>
:)
- Ben Mahler
On Feb. 28, 2014, 8:55 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18642/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2014, 8:55 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 2f4ab256a5cee6a416b353316f6bd4eeec4f95f7
> src/linux/cgroups.cpp 4bf7f26ce96b96b91ebe653b31fa9c27a9ee0a21
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 160e8fe5eb06a2f65924734157b7b8d468d8be36
>
> Diff: https://reviews.apache.org/r/18642/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 18642: Refactored cpu control writes.
Posted by Vinod Kone <vi...@gmail.com>.
> On Feb. 28, 2014, 9:01 p.m., Dominic Hamon wrote:
> > src/linux/cgroups.cpp, line 1958
> > <https://reviews.apache.org/r/18642/diff/1/?file=507098#file507098line1958>
> >
> > what happens if shares > 1024? My understanding is the default is the total is 1024 so setting this to 100 would give ~10%. Should we bounds check?
there is no upper limit per kernel docs. but if the kernel doesn't like it it would give an error.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18642/#review35845
-----------------------------------------------------------
On Feb. 28, 2014, 8:55 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18642/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2014, 8:55 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 2f4ab256a5cee6a416b353316f6bd4eeec4f95f7
> src/linux/cgroups.cpp 4bf7f26ce96b96b91ebe653b31fa9c27a9ee0a21
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 160e8fe5eb06a2f65924734157b7b8d468d8be36
>
> Diff: https://reviews.apache.org/r/18642/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 18642: Refactored cpu control writes.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18642/#review35845
-----------------------------------------------------------
src/linux/cgroups.cpp
<https://reviews.apache.org/r/18642/#comment66618>
what happens if shares > 1024? My understanding is the default is the total is 1024 so setting this to 100 would give ~10%. Should we bounds check?
src/linux/cgroups.cpp
<https://reviews.apache.org/r/18642/#comment66619>
uint64_t? or do you expect negative values?
- Dominic Hamon
On Feb. 28, 2014, 12:55 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18642/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2014, 12:55 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 2f4ab256a5cee6a416b353316f6bd4eeec4f95f7
> src/linux/cgroups.cpp 4bf7f26ce96b96b91ebe653b31fa9c27a9ee0a21
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 160e8fe5eb06a2f65924734157b7b8d468d8be36
>
> Diff: https://reviews.apache.org/r/18642/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>