You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2018/04/13 11:48:56 UTC
[GitHub] carbondata pull request #2172: [CARBONDATA-2333] Block insert overwrite if a...
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2172
[CARBONDATA-2333] Block insert overwrite if all partition columns are not present in an…
…y one of the datamaps
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata preagg_partition_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2172
----
commit 5c53f555d3a46b1a0961b7eb82e7ba5df628e994
Author: kunal642 <ku...@...>
Date: 2018-04-11T11:22:08Z
block insert overwrite if all partition columns are not present in any one of the datamaps
----
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5525/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for drop partition ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4047/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5507/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5067/
---
[GitHub] carbondata pull request #2172: [CARBONDATA-2333] Add validation for drop par...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2172#discussion_r183012262
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala ---
@@ -73,18 +74,9 @@ case class PreAggregateTableHelper(
Seq()
}
// Generate child table partition columns in the same order as the parent table.
- val partitionerFields = fieldRelationMap.collect {
- case (field, dataMapField) if parentPartitionColumns
- .exists(parentCol =>
- /* For count(*) while Pre-Aggregate table creation,columnTableRelationList was null */
- dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&
- parentCol.equals(dataMapField.columnTableRelationList.get.head.parentColumnName) &&
- dataMapField.aggregateFunction.isEmpty) =>
- (PartitionerField(field.name.get,
- field.dataType,
- field.columnComment), parentPartitionColumns
- .indexOf(dataMapField.columnTableRelationList.get.head.parentColumnName))
- }.toSeq.sortBy(_._2).map(_._1)
+ val partitionerFields =
+ PartitionUtils.getPartitionerFields(parentPartitionColumns, fieldRelationMap)
--- End diff --
fixed
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5247/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3845/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3823/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4159/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5416/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4143/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4361/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3804/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5005/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4254/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3853/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5326/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5537/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2172
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4610/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
[GitHub] carbondata pull request #2172: [CARBONDATA-2333] Block insert overwrite if a...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2172#discussion_r181770149
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/PartitionUtils.scala ---
@@ -223,4 +224,41 @@ object PartitionUtils {
}
}
}
+
+ /**
+ * Used to extract Partitioner Fields for aggregation datamaps.
+ *
+ */
+ def getPartitionerFields(partitionColumn: Seq[String],
--- End diff --
Please add detail level comment for this method,
Condition for generating partition filed
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5090/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4057/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5225/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5421/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4342/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4260/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5426/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5340/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5040/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4248/
---
[GitHub] carbondata pull request #2172: [CARBONDATA-2333] Block insert overwrite if a...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2172#discussion_r182136155
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala ---
@@ -73,18 +74,9 @@ case class PreAggregateTableHelper(
Seq()
}
// Generate child table partition columns in the same order as the parent table.
- val partitionerFields = fieldRelationMap.collect {
- case (field, dataMapField) if parentPartitionColumns
- .exists(parentCol =>
- /* For count(*) while Pre-Aggregate table creation,columnTableRelationList was null */
- dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&
- parentCol.equals(dataMapField.columnTableRelationList.get.head.parentColumnName) &&
- dataMapField.aggregateFunction.isEmpty) =>
- (PartitionerField(field.name.get,
- field.dataType,
- field.columnComment), parentPartitionColumns
- .indexOf(dataMapField.columnTableRelationList.get.head.parentColumnName))
- }.toSeq.sortBy(_._2).map(_._1)
+ val partitionerFields =
+ PartitionUtils.getPartitionerFields(parentPartitionColumns, fieldRelationMap)
--- End diff --
dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&
This empty check was added in #2170 is not considered during method extraction. Please fix
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5075/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3940/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3789/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5360/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3871/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5020/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5438/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4374/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Block insert overwrite if all part...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2172
Please update PR description
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4170/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2172
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4449/
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4181/
---
[GitHub] carbondata pull request #2172: [CARBONDATA-2333] Block insert overwrite if a...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2172#discussion_r182956717
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala ---
@@ -73,18 +74,9 @@ case class PreAggregateTableHelper(
Seq()
}
// Generate child table partition columns in the same order as the parent table.
- val partitionerFields = fieldRelationMap.collect {
- case (field, dataMapField) if parentPartitionColumns
- .exists(parentCol =>
- /* For count(*) while Pre-Aggregate table creation,columnTableRelationList was null */
- dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&
- parentCol.equals(dataMapField.columnTableRelationList.get.head.parentColumnName) &&
- dataMapField.aggregateFunction.isEmpty) =>
- (PartitionerField(field.name.get,
- field.dataType,
- field.columnComment), parentPartitionColumns
- .indexOf(dataMapField.columnTableRelationList.get.head.parentColumnName))
- }.toSeq.sortBy(_._2).map(_._1)
+ val partitionerFields =
+ PartitionUtils.getPartitionerFields(parentPartitionColumns, fieldRelationMap)
--- End diff --
fixed
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
[GitHub] carbondata issue #2172: [CARBONDATA-2333] Add validation for insert overwrit...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
[GitHub] carbondata pull request #2172: [CARBONDATA-2333] Add validation for insert o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2172
---