[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3941: Pinot server side change to optimize LLC segment completion with direct metadata upload.

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #3941: Pinot server side change to optimize LLC segment completion with direct metadata upload. 
URL: https://github.com/apache/incubator-pinot/pull/3941#discussion_r265380817
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ServerSegmentCompletionProtocolHandler.java
 ##########
 @@ -50,22 +51,30 @@
   private static SSLContext _sslContext;
   private static Integer _controllerHttpsPort;
 
+  private static boolean _commitWithMetadata;
+
   private final FileUploadDownloadClient _fileUploadDownloadClient;
   private final ServerMetrics _serverMetrics;
 
-  public static void init(Configuration uploaderConfig) {
+  public static void init(Configuration uploaderConfig, boolean commitWithMetadata) {
 
 Review comment:
   Can you move the config of commitWithMetadata to LLRealtimeSegmentDataManager? It is being checked in the other class, so makes sense to move it there. You may have a bit more config plumbing to do, but it is worth it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org